Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:
|
| Section | Status | Recommendation |
|---|---|---|
| Title | Make title more specific or split into two PRs if feasible | |
| Commit Type | ✅ | No changes needed |
| Risk Level | Update to Medium in PR body/labels and add justification | |
| What & Why | ✅ | Expand slightly to clarify intended behavior and cause |
| Impact of Change | Expand impact to include developers & system notes | |
| Test Plan | ✅ | Good — add unit test for useHandoffActionsForAgent or manual test steps for autosave |
| Contributors | ✅ | OK (optional: add more names if applicable) |
| Screenshots/Videos | Consider adding a screenshot of the autosave badge/error tooltip |
Final message
Please update the PR body to state the Risk Level as Medium (or justify Low with additional tests / reasoning), and expand the What & Why and Impact sections slightly. If possible, either split the changes into two PRs (selector fix in libs and standalone autosave in apps) or make the title explicitly mention both scopes as you have now but consider the suggested title format for clarity.
Suggested next steps:
- Change risk selection and label to
Mediumand add 1-2 sentence justification (core selector + autosave behavior touches). - Add/mention a unit test for useHandoffActionsForAgent (or provide a manual test checklist demonstrating no consumer breakage).
- Optionally add a screenshot for the new autosave badge/error tooltip.
After these small updates, this PR should be good to merge. Thank you for the clear PR body and for adding unit tests — that makes review much easier!
Last updated: Tue, 10 Feb 2026 17:08:58 GMT
There was a problem hiding this comment.
Pull request overview
This PR optimizes Designer V2 re-render behavior by memoizing selector outputs/callbacks (notably useHandoffActionsForAgent) and updates the Standalone designer’s draft auto-save UX/behavior to be more portal-like.
Changes:
- Memoize
useHandoffActionsForAgentselector creation to reduce unnecessary re-renders. - Optimize
WorkflowParametersPanelby memoizing mapped parameters and stabilizing dispatch callbacks; add unit tests for the panel. - Rework Standalone draft auto-save cadence/notification UI (throttled saves, relative-time badge, error display).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| libs/designer-v2/src/lib/ui/panel/workflowParametersPanel/workflowParametersPanel.tsx | Memoizes parameter mapping and action handlers; currently introduces an any cast for validationErrors. |
| libs/designer-v2/src/lib/ui/panel/workflowParametersPanel/test/workflowParametersPanel.spec.tsx | Adds unit coverage for prop wiring and dispatch handlers (with one assertion gap noted). |
| libs/designer-v2/src/lib/core/state/workflow/workflowSelectors.ts | Optimizes useHandoffActionsForAgent selector memoization by avoiding unstable combined-state selectors. |
| apps/Standalone/src/designer/app/AzureLogicAppsDesigner/DesignerCommandBarV2.tsx | Changes draft auto-save behavior and adds a status badge with relative time + error tooltip. |
libs/designer-v2/src/lib/ui/panel/workflowParametersPanel/workflowParametersPanel.tsx
Outdated
Show resolved
Hide resolved
apps/Standalone/src/designer/app/AzureLogicAppsDesigner/DesignerCommandBarV2.tsx
Show resolved
Hide resolved
apps/Standalone/src/designer/app/AzureLogicAppsDesigner/DesignerCommandBarV2.tsx
Show resolved
Hide resolved
apps/Standalone/src/designer/app/AzureLogicAppsDesigner/DesignerCommandBarV2.tsx
Show resolved
Hide resolved
...signer-v2/src/lib/ui/panel/workflowParametersPanel/__test__/workflowParametersPanel.spec.tsx
Show resolved
Hide resolved
|
📊 Coverage check completed. See workflow run for details. |
useHandoffActionsForAgent hookuseHandoffActionsForAgent hook, standalone improvement
|
📊 Coverage check completed. See workflow run for details. |
Commit Type
Risk Level
What & Why
Optimized the
useHandoffActionsForAgentto not cause as many rerendersAlso improved our standalone auto-saving to better mimic portal's implementation (this does not impact production, it only changes the behavior in standalone which is only used during development)
Impact of Change
useHandoffActionsForAgenthookTest Plan
(DesignerCommandBarV2.tsx does not need testing since it is a dev-only component)
Contributors
@rllyy97
Screenshots/Videos
N/A