feat(v2designer): add feature flags for MCP client tools feature#8970
feat(v2designer): add feature flags for MCP client tools feature#8970
Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | (Optional) mention exact flag names for extra clarity |
| Commit Type | ✅ | No change needed |
| Risk Level | ✅ | No change needed |
| What & Why | Clarify hostOptions path and default behavior | |
| Impact of Change | Fill out Users/System sections with concrete effects | |
| Test Plan | ✅ | Ensure CI passes; consider E2E if available |
| Contributors | Add contributor credits or a short note | |
| Screenshots/Videos | ✅ | Not required |
Final Notes
This PR passes the PR-title/body checks and I agree with the risk:low label based on the diff (small, localized UI flags + tests). Please update the What & Why and Impact sections with the suggested clarifications and add contributors (if any). After those small edits, this PR should be ready to merge.
Thank you for the clear PR and the added unit tests — they made validation straightforward!
Last updated: Fri, 27 Mar 2026 16:17:47 GMT
There was a problem hiding this comment.
Pull request overview
Adds host-configurable feature flags to optionally hide MCP client tools entry points in the v2 designer browse experience.
Changes:
- Introduces
disableMcpClientToolsanddisableNativeMcpClientToolshost options (interfaces + selector hooks). - Gates the MCP Servers category and parts of the MCP Servers browse UI behind these flags.
- Updates/extends unit tests for category visibility logic.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/designer-v2/src/lib/ui/panel/recommendation/browse/mcpServersBrowse.tsx | Hides the “Others” tab and removes native MCP items when disableNativeMcpClientTools is enabled. |
| libs/designer-v2/src/lib/ui/panel/recommendation/browse/helper.ts | Adds disableMcpClientTools parameter to hide the MCP Servers browse category. |
| libs/designer-v2/src/lib/ui/panel/recommendation/browse/browseView.tsx | Reads disableMcpClientTools and passes it into category generation. |
| libs/designer-v2/src/lib/ui/panel/recommendation/browse/test/helper.spec.ts | Adds tests for disableMcpClientTools visibility behavior. |
| libs/designer-v2/src/lib/core/state/designerOptions/designerOptionsSelectors.ts | Adds selector hooks for the new flags. |
| libs/designer-v2/src/lib/core/state/designerOptions/designerOptionsInterfaces.ts | Extends hostOptions interface with the two new flags. |
| apps/Standalone/src/designer/state/workflowLoadingSlice.ts | Sets default values for the new host options in the Standalone harness (currently type-mismatched). |
libs/designer-v2/src/lib/core/state/designerOptions/designerOptionsSelectors.ts
Show resolved
Hide resolved
libs/designer-v2/src/lib/ui/panel/recommendation/browse/mcpServersBrowse.tsx
Show resolved
Hide resolved
📊 Coverage CheckThe following changed files need attention:
Please add tests for the uncovered files before merging. |
Commit Type
Risk Level
What & Why
Add disableMcpClientTools and disableNativeMcpClientTools feature flags. If not set, default will be false. These flags allow partners to hide the MCP servers category and the native built-in MCP client tools tab in the Browse panel.
Impact of Change
feature could be hidden
Partners will use this flag to hide two features for their customers
Test Plan
Contributors
Screenshots/Videos