Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | Keep as-is or slightly shorten |
| Commit Type | ✅ | No change needed |
| Risk Level | Change to risk:medium or add strong justification for low |
|
| What & Why | ✅ | Fine; optionally call out auth change explicitly |
| Impact of Change | ✅ | Add backend/auth note if relevant |
| Test Plan | ✅ | Add/instrument E2E/integration test for ARM run if possible |
| Contributors | Optional: list others if applicable | |
| Screenshots/Videos | N/A is fine |
Final notes:
- The PR body is well-formed and follows the required template. Unit tests for the URL generation were added and the change is small and well-contained.
- I advise upgrading the risk label to
risk:mediumdue to the change in invocation/authentication surface for published workflow runs. If you believe the change is indeed low-risk, please add a clear justification in the PR body explaining why (for example, detail why ARM auth will behave identically for all consumers and why no production impact is expected). - Please consider adding an integration or E2E test to exercise the authenticated ARM /run invocation path, or add an explanation for why such a test is unnecessary.
Please update the PR labels/body to reflect the chosen risk level (or provide the rationale for keeping risk:low), and optionally add an integration/E2E test (or justification) before merging. Thank you for the clear PR and thorough unit tests!
Last updated: Wed, 08 Apr 2026 18:08:46 GMT
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Designer V2 published-workflow “Run” behavior to match V1 by invoking triggers via an ARM-authenticated /run endpoint rather than retrieving and invoking a SAS-signed callback URL via listCallbackUrl.
Changes:
- Removes
WorkflowService().getCallbackUrl()usage fromFloatingRunButtonfor published runs. - Constructs an ARM
/runURL for both consumption and standard workflows and passes it toRunService().runTrigger. - Reduces one network call per published run (no pre-fetch of callback URL).
📊 Coverage CheckNo source files changed in this PR. |
Elaina-Lee
approved these changes
Apr 8, 2026
rllyy97
added a commit
that referenced
this pull request
Apr 8, 2026
…s instead of listCallbackUrl (#9033) Fixed published wf run path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
Fixes #8870 - The V2 designer was using the listCallbackUrl endpoint to get a SAS-signed URL, then invoking the trigger directly via that URL (no ARM auth). This differs from V1, which POSTs directly to the /triggers/{triggerName}/run ARM endpoint with ARM authentication.
This changes the V2 FloatingRunButton to construct the ARM /run URL directly for published workflows, matching V1 behavior.
Impact of Change
Test Plan
Manually tested, behavior matches V1 behavior now.
Contributors
@rllyy97
Screenshots/Videos
N/A