Skip to content

fix(DesignerV2): Fix Consumption resubmit (Retry) URL missing workflowId path (v5.961)#9230

Merged
rllyy97 merged 2 commits into
hotfix/v5.961from
rllyy97/fix/consumption-resubmit-url-hotfix-v5.961
Jun 1, 2026
Merged

fix(DesignerV2): Fix Consumption resubmit (Retry) URL missing workflowId path (v5.961)#9230
rllyy97 merged 2 commits into
hotfix/v5.961from
rllyy97/fix/consumption-resubmit-url-hotfix-v5.961

Conversation

@rllyy97
Copy link
Copy Markdown
Contributor

@rllyy97 rllyy97 commented Jun 1, 2026 •
edited
Loading

Commit Type

  • fix - Bug fix

Risk Level

  • Low - Minor changes, limited scope

What & Why

Fixes #9194 — The Retry button in the run history blade for Consumption Logic Apps was failing silently with 404 errors.

ConsumptionRunService.resubmitRun() was constructing the resubmit API URL without the workflowId path segment, resulting in requests to https://management.azure.com/triggers/... instead of the correct https://management.azure.com/{workflowId}/triggers/....

Added workflowId to the URL template, matching the pattern used by other methods in the same class (e.g., getRuns(), getScopeRepetitions()).

Impact of Change

  • Users: Retry button in Consumption run history blade now works correctly
  • Developers: None
  • System: None

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in: Verified via HAR file analysis that resubmit URLs were returning 404; confirmed fix produces correct URL with workflowId. All 310 existing unit tests pass.

Contributors

Screenshots/Videos

@rllyy97
fix(DesignerV2): Fix Consumption resubmit (Retry) URL missing workflo…
6ea7b0d 
…wId path (#9222)

* Fix Consumption resubmit URL missing workflowId path

The ConsumptionRunService.resubmitRun() method was constructing the
resubmit URL without the workflowId path segment, resulting in requests
to 'https://management.azure.com/triggers/...' instead of the correct
'https://management.azure.com/{workflowId}/triggers/...'. This caused
404 errors when clicking the Retry button in the run history blade.

Fixes #9194

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add unit tests for ConsumptionRunService.resubmitRun

Verifies the resubmit URL includes workflowId, covers ARM resource
paths, and tests error handling.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Throw instead of returning Error in resubmitRun

Change resubmitRun to throw on failure so useMutation correctly
surfaces errors to callers instead of silently resolving.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 1, 2026 16:30
@rllyy97 rllyy97 changed the base branch from main to hotfix/v5.961 June 1, 2026 16:30
@rllyy97 rllyy97 added risk:low Low risk change with minimal impact DesignerV2 labels Jun 1, 2026
@rllyy97 rllyy97 enabled auto-merge (squash) June 1, 2026 16:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026 •
edited
Loading

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

  • Current: fix(DesignerV2): Fix Consumption resubmit (Retry) URL missing workflowId path (v5.961)
  • Issue: None. The title is specific, includes the area impacted, and clearly describes the fix.
  • Recommendation: No change needed.

✅ Commit Type

  • Properly selected (fix).
  • Only one commit type is selected, which is correct.

✅ Risk Level

  • The selected risk level (Low) matches the diff: a targeted URL construction fix with limited scope and accompanying tests.

✅ What & Why

  • Current: Clear and sufficiently detailed.
  • Issue: None. It explains the bug, the root cause, and the fix.
  • Recommendation: No change needed.

✅ Impact of Change

  • The impact statement is accurate and appropriately scoped.
  • Recommendation:
    • Users: Retry button now works for Consumption run history.
    • Developers: No meaningful API or pattern changes beyond the corrected URL path.
    • System: No broader system impact expected.

✅ Test Plan

  • Passed. The diff includes unit tests for ConsumptionRunService.resubmitRun, which satisfies the test-plan requirement.
  • Manual testing is also described, and the added tests verify the URL construction and failure behavior.

✅ Contributors

  • Blank, but acceptable. This section is optional.

✅ Screenshots/Videos

  • Not applicable for this non-visual change. Blank is acceptable.

Summary Table

Section Status Recommendation
Title ✅ None
Commit Type ✅ None
Risk Level ✅ None
What & Why ✅ None
Impact of Change ✅ None
Test Plan ✅ None
Contributors ✅ Optional section; no action needed
Screenshots/Videos ✅ Not required for this change

The PR passes review for title/body compliance. The advised risk level is low and matches the submitter's assessment.

Last updated: Mon, 01 Jun 2026 17:25:30 GMT

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

  • Current: fix(DesignerV2): Fix Consumption resubmit (Retry) URL missing workflowId path (v5.961)
  • Issue: None — the title is specific, descriptive, and aligned with the change.
  • Recommendation: No change needed.

✅ Commit Type

  • Properly selected (fix).
  • Only one commit type is selected, which is correct.

✅ Risk Level

  • The selected label/body risk is Low, and that matches the scope and impact of the diff. I did not find a higher risk level warranted from the change set.

✅ What & Why

  • Current: Clear explanation of the missing workflowId path segment, the resulting 404s, and the fix.
  • Issue: None.
  • Recommendation: No change needed.

✅ Impact of Change

  • The impact section is concise and appropriate for this fix.
  • Recommendation:
    • Users: Correctly identifies retry behavior for Consumption run history.
    • Developers: None is acceptable here.
    • System: None is acceptable here.

✅ Test Plan

  • Test plan passes: unit tests were added/updated in the diff, and manual testing is also documented.
  • The added unit tests cover the URL construction and failure behavior, which is sufficient.

⚠️ Contributors

  • Blank section is acceptable, but if others contributed ideas/review/implementation, please add them for credit.

✅ Screenshots/Videos

  • No screenshots/videos are needed because this is not a visual change.

Summary Table

Section Status Recommendation
Title ✅ No change needed
Commit Type ✅ No change needed
Risk Level ✅ No change needed
What & Why ✅ No change needed
Impact of Change ✅ No change needed
Test Plan ✅ No change needed
Contributors ⚠️ Optional: add names if anyone else contributed
Screenshots/Videos ✅ No change needed

PR passed. The advised risk level remains low and does not exceed the submitter's estimate.

Last updated: Mon, 01 Jun 2026 16:33:33 GMT

Copilot AI reviewed Jun 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a bug in ConsumptionRunService.resubmitRun() where the resubmit API URL was missing the workflowId path segment, causing 404 errors on the Retry button in the Consumption run history blade. Also corrects an error-handling bug where failures were being returned instead of thrown, silently swallowing errors.

Changes:

  • Inject workflowId from options and include it in the resubmit URL template, matching the pattern used by sibling methods (getRuns, getScopeRepetitions).
  • Change return new Error(...) to throw new Error(...) so resubmit failures actually propagate to callers.
  • Add unit tests covering URL construction (including ARM resource paths) and error propagation.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
libs/logic-apps-shared/src/designer-client-services/lib/consumption/run.ts Adds workflowId to the resubmit URL and throws (rather than returns) on failure.
libs/logic-apps-shared/src/designer-client-services/lib/consumption/tests/run.spec.ts New resubmitRun tests for URL construction with workflowId and error propagation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

📊 Coverage Check

The following changed files need attention:

⚠️ libs/logic-apps-shared/src/designer-client-services/lib/consumption/run.ts - 20% covered (needs improvement)

Please add tests for the uncovered files before merging.

@rllyy97 rllyy97 merged commit 933cabe into hotfix/v5.961 Jun 1, 2026
13 of 14 checks passed
@rllyy97 rllyy97 deleted the rllyy97/fix/consumption-resubmit-url-hotfix-v5.961 branch June 1, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@lambrianmsft lambrianmsft lambrianmsft approved these changes

Assignees

No one assigned

Labels

DesignerV2 pr-validated risk:low Low risk change with minimal impact

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[New Experiment]: 'Retry' Button fails to trigger workflow in run history blade

3 participants

@rllyy97 @lambrianmsft