Merged
Conversation
romanlutz
reviewed
Dec 7, 2025
…n_tests/add_uv
…n_tests/add_uv
hannahwestra25
commented
Dec 17, 2025
jsong468
reviewed
Dec 18, 2025
ValbuenaVC
reviewed
Dec 18, 2025
rlundeen2
reviewed
Dec 18, 2025
rlundeen2
reviewed
Dec 18, 2025
rlundeen2
approved these changes
Dec 18, 2025
Contributor
rlundeen2
left a comment
rlundeen2
left a comment
There was a problem hiding this comment.
Looks great to me! I'd just be careful in verifying
- A user can install it using docker
- A user can install it using the uv setup
- Our three CI pipelines install pyrit successfully (github, end-to-end, and integration)
romanlutz
approved these changes
Dec 18, 2025
Contributor
romanlutz
left a comment
romanlutz
left a comment
There was a problem hiding this comment.
Is it fair to assume you ran this inside and outside the devcontainer?
We'll have to try out the GCG workflow again at some point but our AML resource is not working at this time 🙁 Don't block on that for sure.
ValbuenaVC
reviewed
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces conda with uv for package / environment management in our dockerfile and build pipelines. Also directs users to use uv rather than conda and removes references to conda in documentation
Tests and Documentation