MAINT: Fixing Retry configuration so it works from .env#1256
Merged
rlundeen2 merged 1 commit intoAzure:mainfrom Dec 16, 2025
Merged
MAINT: Fixing Retry configuration so it works from .env#1256rlundeen2 merged 1 commit intoAzure:mainfrom
rlundeen2 merged 1 commit intoAzure:mainfrom
Conversation
romanlutz
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR happened because @romanlutz (correctly) pointed out globals are a bad practice. I remembered them not working otherwise, but I had a tough time remembering the circumstances.
Now I remember, because my PR above broke it! To repro, add this to a .env file
And if you run a notebook, it will still retry 10 times (or whatever your environment variable was set to before running pyrit).
Because it was loaded at initialization time, the .env file loading was not respected. And in fact, it did work with the globals, but no longer does. But with this fix, the exceptions class dynamically gets the number and avoids globals :)