Preserve raw HTTP body whitespace in HTTPTarget#1495
Open
biefan wants to merge 1 commit intoAzure:mainfrom
Open
Preserve raw HTTP body whitespace in HTTPTarget#1495biefan wants to merge 1 commit intoAzure:mainfrom
biefan wants to merge 1 commit intoAzure:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTTPTarget.parse_raw_http_request()text/plainand other non-JSON bodiesProblem
HTTPTarget.parse_raw_http_request()currently callsstrip()on the full raw HTTP request before splitting headers from the body.That means body content is not preserved exactly as provided. For example, a raw request body such as:
is parsed as:
This silently rewrites non-JSON request bodies and can break plain text, form data, or any scenario where trailing whitespace is significant.
Testing
.venv/bin/pytest tests/unit/target/test_http_target_parsing.py -q