[Modules] Added Web PubSub module by AlexanderSehr · Pull Request #1621 · Azure/ResourceModules

AlexanderSehr · 2022-06-28T05:52:51Z

Description

Based on PR #1568. Merged originally into dedicated branch to enable testing.

Added a module and docs for Web PubSub implementing the following general features:

Private endpoints
Resource locks
RBAC

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Update to documentation

Checklist

I'm sure there are no other open Pull Requests for the same update/change
My corresponding pipelines / checks run clean and green without any errors or warnings
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (readme)
I did format my code

* feat(webpubsub): Added Web PubSub module * feat(webpubsub): Updated folders, added tests, updated readme * feat(webpubsub): Added nested rbac * fix: Applied suggestions from code review Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * fix(webpubsub): Integrated multiple review feedback * feat(webpubsub): Added json based test parameters * ci(webpubsub): Added devops and github workflow definitions * fix(webpubsub): Updated default sku Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * fix(webpubsub): Updated pipeline variables Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * fix(webpubsub): Updated pipeline variables Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * fix(webpubsub): Updated pipeline variables Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * fix(webpubsub): Deleted .test folder as requested Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>

eriqua

🆗

AlexanderSehr marked this pull request as ready for review June 28, 2022 05:52

AlexanderSehr requested a review from a team as a code owner June 28, 2022 05:52

AlexanderSehr self-assigned this Jun 28, 2022

AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jun 28, 2022

AlexanderSehr added 5 commits June 28, 2022 07:57

Moved mmodule to temp loc

e37c2e9

Merge branch 'main' into users/itpropro/webpubsub

7fdf82a

Merged latest main & moved SignalR to target location

49dd051

Updated SignalR pipelines to latest

70f0663

Several smaller fixes

9292dda

AlexanderSehr enabled auto-merge (squash) June 28, 2022 06:19

AlexanderSehr added 2 commits June 30, 2022 08:09

Merged latest main

72738c4

Merged latest main

5fe2a4c

eriqua reviewed Jul 10, 2022

View reviewed changes

Comment thread modules/Microsoft.SignalRService/webPubSub/.test/full.parameters.json

Renamed file

f9a3d1f

AlexanderSehr requested a review from eriqua July 11, 2022 09:36