Skip to content

[Fixes] SQL - Changed login away from secret as user name is not defined as secure()#1668

Merged
AlexanderSehr merged 1 commit into
mainfrom
users/alsehr/1652_sqlLogin
Jul 14, 2022
Merged

[Fixes] SQL - Changed login away from secret as user name is not defined as secure()#1668
AlexanderSehr merged 1 commit into
mainfrom
users/alsehr/1652_sqlLogin

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Jul 14, 2022

Description

  • Changed login away from secret as user name is not defined as secure()

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Sql: Servers

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner July 14, 2022 19:10
@AlexanderSehr AlexanderSehr self-assigned this Jul 14, 2022
@AlexanderSehr AlexanderSehr added bug Something isn't working [cat] modules category: modules labels Jul 14, 2022
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) July 14, 2022 19:10
@github-actions
Copy link
Copy Markdown

Unit Test Results

    1 files  ±    0      1 suites  ±0   43s ⏱️ +28s
185 tests +144  182 ✔️ +142  3 💤 +2  0 ±0 
186 runs  +145  183 ✔️ +143  3 💤 +2  0 ±0 

Results for commit dd6d95a. ± Comparison against base commit 25c7662.

This pull request removes 41 and adds 185 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ManagedIdentity/userAssignedIdentities] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ManagedIdentity/userAssignedIdentities] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.ManagedIdentity/userAssignedIdentities] used resource type [userAssignedIdentities] should use one of the recent API version(s). Currently using [2018-11-30]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] Location output should be returned for resources that use it
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers/databases] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers/databases] used resource type [servers/databases] should use one of the recent API version(s). Currently using [2021-02-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers/firewallRules] used resource type [servers/firewallRules] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers/securityAlertPolicies] used resource type [servers/securityAlertPolicies] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers/vulnerabilityAssessments] used resource type [servers/vulnerabilityAssessments] should use one of the recent API version(s). Currently using [2021-11-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2021-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Sql/servers] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
…
This pull request removes 1 skipped test and adds 3 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.ManagedIdentity/userAssignedIdentities] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers/firewallRules] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers/securityAlertPolicies] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Sql/servers/vulnerabilityAssessments] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)

@AlexanderSehr AlexanderSehr merged commit ebe3be8 into main Jul 14, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1652_sqlLogin branch July 14, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working [cat] modules category: modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report]: Microsoft.Sql administratorLogin is not designated as a secure string

2 participants