Skip to content

[Utilities] Added quotation for empty allowed values & added sorting#1683

Merged
AlexanderSehr merged 3 commits into
mainfrom
users/alsehr/1487_quotes
Jul 17, 2022
Merged

[Utilities] Added quotation for empty allowed values & added sorting#1683
AlexanderSehr merged 3 commits into
mainfrom
users/alsehr/1487_quotes

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Jul 17, 2022

Description

  • Added quotation for empty allowed values (e.g. [, one, two] is changed to ['', one, two])
  • Added sorting of allowedValues & defaultValues

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AnalysisServices: Servers

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner July 17, 2022 15:26
@AlexanderSehr AlexanderSehr added documentation Improvements or additions to documentation [cat] modules category: modules [cat] utilities category: utilities enhancement New feature or request labels Jul 17, 2022
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) July 17, 2022 15:57
@github-actions
Copy link
Copy Markdown

Unit Test Results

  1 files  ±  0    1 suites  ±0   16s ⏱️ -6s
42 tests  - 37  42 ✔️  - 36  0 💤  - 1  0 ±0 
44 runs   - 36  44 ✔️  - 35  0 💤  - 1  0 ±0 

Results for commit 270b417. ± Comparison against base commit f153f33.

This pull request removes 79 and adds 42 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores/keyValues] used resource type [configurationStores/keyValues] should use one of the recent API version(s). Currently using [2021-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores] used resource type [configurationStores/keyValues] should use one of the recent API version(s). Currently using [2021-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores] used resource type [configurationStores] should use one of the recent API version(s). Currently using [2021-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores] used resource type [privateEndpoints/privateDnsZoneGroups] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores] used resource type [privateEndpoints] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AppConfiguration/configurationStores] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AppConfiguration/configurationStores/keyValues] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AppConfiguration/configurationStores/keyValues] All parameters in parameters files exist in template file (deploy.json)
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [servers] should use one of the recent API version(s). Currently using [2017-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
…

@AlexanderSehr AlexanderSehr merged commit 0e7af49 into main Jul 17, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1487_quotes branch July 17, 2022 21:55
@AlexanderSehr AlexanderSehr changed the title [Utility] Added quotation for empty allowed values & added sorting [Utilities] Added quotation for empty allowed values & added sorting Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules [cat] utilities category: utilities documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Make readme generator show 'Allowed Values' parameter strings with single-quotes.

2 participants