Skip to content

[Modules] Configure privateDnsZoneGroups on app config#1689

Merged
eriqua merged 14 commits into
mainfrom
users/erikag/app-config-pe
Jul 18, 2022
Merged

[Modules] Configure privateDnsZoneGroups on app config#1689
eriqua merged 14 commits into
mainfrom
users/erikag/app-config-pe

Conversation

@eriqua
Copy link
Copy Markdown
Contributor

@eriqua eriqua commented Jul 18, 2022

Description

Closes #1688

Note: Does not solve the issue of the private endpoint on configuration store not being idempotent.

  • Adding private DNS zone group id to associate the private endpoint with a private DNS zone.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AppConfiguration: ConfigurationStores

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@github-actions
Copy link
Copy Markdown

Unit Test Results

  1 files  ±0    1 suites  ±0   21s ⏱️ -1s
79 tests ±0  78 ✔️ ±0  1 💤 ±0  0 ±0 
80 runs  ±0  79 ✔️ ±0  1 💤 ±0  0 ±0 

Results for commit e423763. ± Comparison against base commit f153f33.

@eriqua eriqua marked this pull request as ready for review July 18, 2022 10:01
@eriqua eriqua requested a review from a team as a code owner July 18, 2022 10:01
@eriqua eriqua enabled auto-merge (squash) July 18, 2022 10:01
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Jul 18, 2022
@eriqua eriqua merged commit 914126b into main Jul 18, 2022
@eriqua eriqua deleted the users/erikag/app-config-pe branch July 18, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure privateDnsZoneGroups on app config (configurationStores - privatelink.azconfig.io)

2 participants