Skip to content

[Modules] Configure privateDnsZoneGroups on Web PubSub Service#1696

Merged
eriqua merged 5 commits into
mainfrom
users/erikag/1695-webpubsub-pe
Jul 18, 2022
Merged

[Modules] Configure privateDnsZoneGroups on Web PubSub Service#1696
eriqua merged 5 commits into
mainfrom
users/erikag/1695-webpubsub-pe

Conversation

@eriqua
Copy link
Copy Markdown
Contributor

@eriqua eriqua commented Jul 18, 2022

Description

Closes #1695

  • Adding private DNS zone group id to associate the private endpoint with a private DNS zone.
  • Updating publicNetworkAccess implementation to be disabled by default only if:
    • no explicit value is passed
    • private endpoint parameter is not empty
    • network acls parameter is empty
      This is needed to allow both private endpoint and firewall rules to be applied on the same resource (i.e. set network access to selected networks only)
  • Updating main test to deploy both pe and network acls (to test that public network access stays enabled).
  • Adding pe test to deploy pe alone (to test that public network access gets disabled).
  • Updating parameter description and deployment name typos

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
SignalR Service: Web PubSub

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua added enhancement New feature or request [cat] modules category: modules [cat] testing category: testing labels Jul 18, 2022
@eriqua eriqua requested a review from a team as a code owner July 18, 2022 17:07
@eriqua eriqua enabled auto-merge (squash) July 18, 2022 18:11
Comment thread modules/Microsoft.SignalRService/webPubSub/.test/pe.parameters.json
@eriqua eriqua merged commit 7858ab0 into main Jul 18, 2022
@eriqua eriqua deleted the users/erikag/1695-webpubsub-pe branch July 18, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules [cat] testing category: testing enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure privateDnsZoneGroups on webpubsub (privatelink.webpubsub.azure.com)

2 participants