Skip to content

[Modules] VM: Added proximityPlacementGroup test + changed param format#1760

Merged
AlexanderSehr merged 13 commits into
mainfrom
users/alsehr/1173_vmprox
Aug 8, 2022
Merged

[Modules] VM: Added proximityPlacementGroup test + changed param format#1760
AlexanderSehr merged 13 commits into
mainfrom
users/alsehr/1173_vmprox

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Aug 7, 2022 •
edited
Loading

Description

  • Added reference to proximityPlacementGroup to test files in VM & VMSS
  • Changed format of diverse parameters to request resourceID instead of just name as e.g. the proximityPlacementGroup may be in a different RG or subsciption
  • Replaced ProximityGroupDeployment in VMSS deployment with ProximityGroupResourceID reference to align with VM module

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute: VirtualMachines
Compute: VirtualMachineScaleSets

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner August 7, 2022 13:05
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Aug 7, 2022
@AlexanderSehr AlexanderSehr linked an issue Aug 7, 2022 that may be closed by this pull request
Add testing for VM for proximityPlacementGroups #1173
Closed
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) August 7, 2022 13:06
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 7, 2022 •
edited
Loading

Unit Test Results

  1 files    1 suites   23s ⏱️
79 tests 78 ✔️ 1 💤 0 ❌
82 runs  81 ✔️ 1 💤 0 ❌

Results for commit 1f6b705.

♻️ This comment has been updated with latest results.

eriqua
eriqua reviewed Aug 7, 2022
View reviewed changes
Comment thread .github/workflows/platform.dependencies.yml Outdated
eriqua
eriqua reviewed Aug 7, 2022
View reviewed changes
Comment thread .github/workflows/platform.dependencies.yml Outdated
eriqua
eriqua reviewed Aug 7, 2022
View reviewed changes
Comment thread .azuredevops/platformPipelines/platform.dependencies.yml
eriqua
eriqua reviewed Aug 7, 2022
View reviewed changes
Comment thread modules/Microsoft.Compute/virtualMachines/readme.md Outdated
eriqua
eriqua reviewed Aug 7, 2022
View reviewed changes
Comment thread modules/Microsoft.Compute/virtualMachines/readme.md Outdated
eriqua
eriqua reviewed Aug 7, 2022
View reviewed changes
Comment thread modules/Microsoft.Compute/virtualMachines/deploy.bicep Outdated
eriqua
eriqua reviewed Aug 7, 2022
View reviewed changes
Comment thread modules/Microsoft.Compute/virtualMachines/deploy.bicep Outdated
eriqua
eriqua reviewed Aug 7, 2022
View reviewed changes
Comment thread modules/Microsoft.Compute/virtualMachines/deploy.bicep
AlexanderSehr and others added 9 commits August 7, 2022 19:48
@AlexanderSehr @eriqua
Update modules/Microsoft.Compute/virtualMachines/readme.md
ec160e0 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Compute/virtualMachines/readme.md
f5c708c 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Compute/virtualMachines/deploy.bicep
2561001 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update modules/Microsoft.Compute/virtualMachines/deploy.bicep
629ca68 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr
Update to latest
2cd4877
@AlexanderSehr @eriqua
Update .github/workflows/platform.dependencies.yml
95cde6f 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr @eriqua
Update .github/workflows/platform.dependencies.yml
aa8a1ce 
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr
Merge branch 'users/alsehr/1173_vmprox' of https://github.com/Azure/R…
d327daa 
…esourceModules into users/alsehr/1173_vmprox
@AlexanderSehr
Aligned vmss
1f6b705
@AlexanderSehr AlexanderSehr requested a review from eriqua August 7, 2022 18:35
eriqua
eriqua reviewed Aug 7, 2022
View reviewed changes
Comment thread modules/Microsoft.Compute/virtualMachines/version.json
@AlexanderSehr AlexanderSehr requested a review from eriqua August 8, 2022 06:43
@AlexanderSehr AlexanderSehr merged commit 5042c3d into main Aug 8, 2022
eriqua
eriqua approved these changes Aug 8, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr deleted the users/alsehr/1173_vmprox branch August 8, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add testing for VM for proximityPlacementGroups

2 participants

@AlexanderSehr @eriqua