Skip to content

[Fixes] Updated helper to reference the new script for cross reference#1768

Merged
ahmadabdalla merged 1 commit into
mainfrom
users/ahmad/bugFix_Pester2
Aug 8, 2022
Merged

[Fixes] Updated helper to reference the new script for cross reference#1768
ahmadabdalla merged 1 commit into
mainfrom
users/ahmad/bugFix_Pester2

Conversation

@ahmadabdalla
Copy link
Copy Markdown
Contributor

@ahmadabdalla ahmadabdalla commented Aug 8, 2022

Description

The pester script was not able to use the new 'cross reference' script as it was not defined in the helper. This fixes the issue

Pipeline
Network: ApplicationSecurityGroups

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added [prio] high importance of the issue: high priority bug Something isn't working labels Aug 8, 2022
@ahmadabdalla ahmadabdalla marked this pull request as ready for review August 8, 2022 21:43
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner August 8, 2022 21:44
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 8, 2022

Unit Test Results

  1 files  ±  0    1 suites  ±0   18s ⏱️ +13s
43 tests +35  42 ✔️ +34  1 💤 +1  0 ±0 
43 runs  +34  42 ✔️ +33  1 💤 +1  0 ±0 

Results for commit 88b90c5. ± Comparison against base commit 731350c.

This pull request removes 8 and adds 43 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Cache/redis] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Cache/redis] folder should contain one or more *parameters.json files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Cache/redis] Module should contain a [.test] folder
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Cache/redis] Module should contain a [deploy.json/deploy.bicep] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Cache/redis] Module should contain a [readme.md] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Cache/redis] Module should contain a [version.json] file
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Cache/redis] Module should have a GitHub workflow
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests.General module folder tests.[Microsoft.Cache/redis] Module should have an Azure DevOps pipeline
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/applicationSecurityGroups] used resource type [applicationSecurityGroups] should use one of the recent API version(s). Currently using [2021-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/applicationSecurityGroups] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/applicationSecurityGroups] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2020-10-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationSecurityGroups] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationSecurityGroups] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationSecurityGroups] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationSecurityGroups] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationSecurityGroups] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationSecurityGroups] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/applicationSecurityGroups] If delete lock is implemented, the template should have a lock parameter with the default value of ['']
…

@ahmadabdalla ahmadabdalla merged commit bc8fba5 into main Aug 8, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/bugFix_Pester2 branch August 8, 2022 21:51
@eriqua eriqua changed the title [Bug Fix] Updated helper to reference the new script for cross reference [Fixes] Updated helper to reference the new script for cross reference Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working [prio] high importance of the issue: high priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants