Skip to content

[CI environment] Added new dependencies and updated pls resources references#1804

Merged
ahmadabdalla merged 1 commit into
mainfrom
users/ahmad/bugFix_PLS_dependency
Aug 27, 2022
Merged

[CI environment] Added new dependencies and updated pls resources references#1804
ahmadabdalla merged 1 commit into
mainfrom
users/ahmad/bugFix_PLS_dependency

Conversation

@ahmadabdalla
Copy link
Copy Markdown
Contributor

@ahmadabdalla ahmadabdalla commented Aug 26, 2022

closes #1803

Description

Private Link services rely on dependences that don't allow it to be successfully deployed. Two issues:

  • The Azure Load Balancer frontend cannot be referenced from the existing 'internal' dependency load balancer due to NAT rules. Hence created a new PLS load balancer with 2 separate frontends as we cannot create additional frontends with the existing one.
  • The subnets do require private link network policies to be disabled. Hence created new subnets for it.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: PrivateLinkServices

**NOTE ** Dependency pipeline is OK. and failure is not related to this fix

image

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added bug Something isn't working [cat] modules category: modules labels Aug 26, 2022
@ahmadabdalla ahmadabdalla self-assigned this Aug 26, 2022
@ahmadabdalla
Copy link
Copy Markdown
Contributor Author

CC: @kavishshivhare

@ahmadabdalla ahmadabdalla marked this pull request as ready for review August 26, 2022 23:28
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner August 26, 2022 23:28
@ahmadabdalla ahmadabdalla merged commit d24141a into main Aug 27, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/bugFix_PLS_dependency branch August 27, 2022 20:04
@eriqua eriqua changed the title Added new dependencies and updated pls resources references [CI environment] Added new dependencies and updated pls resources references Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working [cat] modules category: modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report]: Private Link Services require dependency updates

2 participants