Skip to content

[Modules] Fixed ADF IntegrationRuntime Bug from Required to Optional and changed to Array instead of Object#1988

Merged
ahmadabdalla merged 3 commits into
mainfrom
users/ahmad/1974_adfbug
Sep 10, 2022
Merged

[Modules] Fixed ADF IntegrationRuntime Bug from Required to Optional and changed to Array instead of Object#1988
ahmadabdalla merged 3 commits into
mainfrom
users/ahmad/1974_adfbug

Conversation

@ahmadabdalla
Copy link
Copy Markdown
Contributor

Description

Closes #1974

  • Updated IntegrationRuntime to be an array instead of an object to deploy multiple of them for an ADF resource
  • Updated Integration runtime typeProperties to be optional, as it is not required when the type is SelfHosted

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
DataFactory: Factories

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added bug Something isn't working [cat] modules category: modules labels Sep 9, 2022
@ahmadabdalla ahmadabdalla added this to the Release 0.7 milestone Sep 9, 2022
@ahmadabdalla ahmadabdalla self-assigned this Sep 9, 2022
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner September 9, 2022 07:53
@ahmadabdalla ahmadabdalla changed the title updated module Fixed ADF IntegrationRuntime Bug from Required to Optional and changed to Array instead of Object Sep 9, 2022
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 9, 2022

Unit Test Results

    1 files      1 suites   1m 4s ⏱️
164 tests 163 ✔️ 1 💤 0
165 runs  164 ✔️ 1 💤 0

Results for commit 937e560.

♻️ This comment has been updated with latest results.

Comment thread modules/Microsoft.DataFactory/factories/readme.md Outdated
@eriqua eriqua changed the title Fixed ADF IntegrationRuntime Bug from Required to Optional and changed to Array instead of Object [Modules] Fixed ADF IntegrationRuntime Bug from Required to Optional and changed to Array instead of Object Sep 9, 2022
@ahmadabdalla ahmadabdalla merged commit 0493fe8 into main Sep 10, 2022
@ahmadabdalla ahmadabdalla deleted the users/ahmad/1974_adfbug branch September 10, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working [cat] modules category: modules

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

[Bug Report]: ADF IntegrationRuntime typeProperties should be optional

3 participants