Skip to content

[Modules] Updated Network DDOS Proction Plans to new dependencies approach#2054

Merged
AlexanderSehr merged 4 commits intomainfrom
users/alsehr/1791_Network_ddosProtectionPlans
Oct 7, 2022
Merged

[Modules] Updated Network DDOS Proction Plans to new dependencies approach#2054
AlexanderSehr merged 4 commits intomainfrom
users/alsehr/1791_Network_ddosProtectionPlans

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Sep 18, 2022

Description

  • Updated Network DDOS Proction Plans to new dependencies approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: DdosProtectionPlans

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Sep 18, 2022
@AlexanderSehr AlexanderSehr added [cat] modules category: modules [cat] testing category: testing labels Sep 18, 2022
@AlexanderSehr AlexanderSehr linked an issue Sep 18, 2022 that may be closed by this pull request
Update Network/ddosProtectionPlans to new dependencies approach #2053
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 18, 2022

Unit Test Results

  1 files    1 suites   38s ⏱️
52 tests 50 ✔️ 2 💤 0 ❌
59 runs  56 ✔️ 3 💤 0 ❌

Results for commit 615d27b.

AlexanderSehr
AlexanderSehr commented Sep 18, 2022
View reviewed changes
Comment thread modules/Microsoft.Network/ddosProtectionPlans/.test/common/deploy.test.bicep Outdated
AlexanderSehr
AlexanderSehr commented Sep 18, 2022
View reviewed changes
Comment thread modules/Microsoft.Network/ddosProtectionPlans/.test/min/deploy.test.bicep Outdated
@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 18, 2022 21:41
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 18, 2022 21:41
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 18, 2022 21:41
@AlexanderSehr AlexanderSehr merged commit 6e7043d into main Oct 7, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/1791_Network_ddosProtectionPlans branch October 7, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahalan rahalan rahalan approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Network/ddosProtectionPlans to new dependencies approach

2 participants

@AlexanderSehr @rahalan