Skip to content

[Modules] Updated Insight ActivityLogAlerts to new dependencies approach#2203

Merged
lsnoddy merged 13 commits intoAzure:mainfrom
lsnoddy:users/lsnoddy/activlityLogAlerts
Nov 1, 2022
Merged

[Modules] Updated Insight ActivityLogAlerts to new dependencies approach#2203
lsnoddy merged 13 commits intoAzure:mainfrom
lsnoddy:users/lsnoddy/activlityLogAlerts

Conversation

@lsnoddy
Copy link
Copy Markdown
Member

@lsnoddy lsnoddy commented Oct 11, 2022

Description

Updated Insight ActivityLogAlerts to new dependencies approach

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Insights: ActivityLogAlerts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@lsnoddy lsnoddy added [cat] modules category: modules [cat] testing category: testing labels Oct 11, 2022
@lsnoddy lsnoddy requested a review from a team as a code owner October 11, 2022 13:20
@lsnoddy lsnoddy self-assigned this Oct 11, 2022
@lsnoddy lsnoddy linked an issue Oct 11, 2022 that may be closed by this pull request
Update Insights/activityLogAlerts to new dependencies approach #2196
Closed
@eriqua eriqua changed the title Updated Insight ActivityLogAlerts to new dependencies approach [Modules] Updated Insight ActivityLogAlerts to new dependencies approach Oct 11, 2022
AlexanderSehr
AlexanderSehr reviewed Oct 11, 2022
View reviewed changes
Comment thread modules/Microsoft.Insights/activityLogAlerts/.test/common/dependencies.bicep Outdated
@lsnoddy lsnoddy merged commit c9bdddd into Azure:main Nov 1, 2022
@lsnoddy lsnoddy deleted the users/lsnoddy/activlityLogAlerts branch November 1, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderSehr AlexanderSehr AlexanderSehr approved these changes

Assignees

@lsnoddy lsnoddy

Labels

[cat] modules category: modules [cat] testing category: testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Insights/activityLogAlerts to new dependencies approach

3 participants

@lsnoddy @AlexanderSehr @eriqua