Skip to content

[Utilities] Updated the deployment name generation to be more detailed#2282

Merged
AlexanderSehr merged 7 commits intomainfrom
users/alsehr/2276_deploymentName
Nov 8, 2022
Merged

[Utilities] Updated the deployment name generation to be more detailed#2282
AlexanderSehr merged 7 commits intomainfrom
users/alsehr/2276_deploymentName

Conversation

@AlexanderSehr
Copy link
Copy Markdown
Contributor

@AlexanderSehr AlexanderSehr commented Nov 4, 2022

Description

  • Adjusted the deployment name logic to regenerate it each time a retry takes place (added with a t# in the end)
  • Also incorporated the module's name in case the template's file path allows it

Examples

  • Analysis Servies
    image
  • Key Vault
    VERBOSE: Deploying with deployment name [KeyVault-vaults-min-20221104T2011351293Z-t1]
    VERBOSE: Deploying with deployment name [KeyVault-vaults-min-20221104T2011411996Z-t2]
    VERBOSE: Deploying with deployment name [KeyVault-vaults-min-20221104T2011437597Z-t3]
    

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AnalysisServices: Servers
KeyVault: Vaults (unrelated failing pipeline)

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Nov 4, 2022
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] utilities category: utilities labels Nov 4, 2022
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 4, 2022

Unit Test Results

  1 files  ±  0    1 suites  ±0   47s ⏱️ +13s
53 tests  -   1  52 ✔️ +  1  1 💤  - 1  0  - 1 
70 runs  +16  67 ✔️ +16  3 💤 +1  0  - 1 

Results for commit c7a76a8. ± Comparison against base commit 42be8c6.

This pull request removes 54 and adds 53 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/dnsResolvers] used resource type [dnsResolvers/inboundEndpoints] should use one of the recent API version(s). Currently using [2022-07-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/dnsResolvers] used resource type [dnsResolvers/outboundEndpoints] should use one of the recent API version(s). Currently using [2022-07-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/dnsResolvers] used resource type [dnsResolvers] should use one of the recent API version(s). Currently using [2022-07-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/dnsResolvers] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.Network/dnsResolvers] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/dnsResolvers] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/dnsResolvers] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/dnsResolvers] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/dnsResolvers] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/dnsResolvers] CUA ID deployment should be present in the template
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [diagnosticsettings] should use one of the recent API version(s). Currently using [2021-05-01-preview]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [locks] should use one of the recent API version(s). Currently using [2017-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests [All apiVersions in the template should be 'recent'].In [Microsoft.AnalysisServices/servers] used resource type [servers] should use one of the recent API version(s). Currently using [2017-08-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.AnalysisServices/servers] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
…
This pull request removes 2 skipped tests and adds 1 skipped test. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.Deployment template tests.[Microsoft.Network/dnsResolvers] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Network/dnsResolvers] *parameters.json files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.AnalysisServices/servers] *parameters.json files in the .test folder should be valid json

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 4, 2022 20:36
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner November 4, 2022 20:36
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 4, 2022 20:37
Comment thread utilities/pipelines/resourceDeployment/New-TemplateDeployment.ps1 Outdated
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
@AlexanderSehr AlexanderSehr requested a review from eriqua November 7, 2022 11:44
Copy link
Copy Markdown
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 659aec1 into main Nov 8, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/2276_deploymentName branch November 8, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] utilities category: utilities enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Move the deployment name generation into the retry loop

2 participants