Skip to content

[Modules] Update AKS Orchestrator version when upgrade.#2312

Merged
AlexanderSehr merged 4 commits intomainfrom
users/jpeasier/FixUpdateKubernetesVersionOnNodePool
Nov 12, 2022
Merged

[Modules] Update AKS Orchestrator version when upgrade.#2312
AlexanderSehr merged 4 commits intomainfrom
users/jpeasier/FixUpdateKubernetesVersionOnNodePool

Conversation

@JPEasier
Copy link
Copy Markdown
Contributor

Description

Problem:

When the AKS is deployed with a default or spezific Version and then redeploy with a newer Version,
the module updates only the Kubernetes control plane not the node pools.
Screenshot 2022-11-11 113257
As a best practice, you should upgrade all node pools in an AKS cluster to the same Kubernetes version.

Solution:

The Operational version will be set to the Kubernetes version if it's set in parameters.

  • Update API version

Pipeline references

Pipeline
ContainerService: ManagedClusters

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@JPEasier JPEasier added bug Something isn't working [cat] modules category: modules labels Nov 11, 2022
@JPEasier JPEasier requested a review from a team as a code owner November 11, 2022 13:45
@JPEasier JPEasier self-assigned this Nov 11, 2022
@AlexanderSehr
Copy link
Copy Markdown
Contributor

Great work!

@eriqua eriqua changed the title update AKS Orchestrator version when upgrade. [Modules] Update AKS Orchestrator version when upgrade. Nov 11, 2022
@JPEasier
Copy link
Copy Markdown
Contributor Author

I will fix the pipeline run, somthing with the new api version.

@JPEasier
Copy link
Copy Markdown
Contributor Author

I take a deeper look into the deployment locally.
The deployment fails at the provisioning of the VMSS for nodePools.
in the dependencies we using a keyVault for diskEncryptionSet and this one needs Purge Protection activated.

Message

The key vault 'dep-jpe-kv-csmazure' used for disk encryption set 'dep-jpe-des-csmazure' must have purge protection enabled. Target: 'VM: '/subscriptions/b688a246-149f-4e7b-9ac4-15a993403b69/resourceGroups/ms.containerservice.managedclusters-csmazure-rg_aks_jpecsmazure001_nodes/providers/Microsoft.Compute/virtualMachineScaleSets/aks-systempool-16738708-vmss/virtualMachines/aks-systempool-16738708-vmss_9', disk: 'OSDisk''.

As a KeyVault with purge protection for the deploy and throw away approach is not posible due to the retaition time
schould we remove this from the module?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 11, 2022

Unit Test Results

    1 files    1 suites   47s ⏱️
  90 tests 89 ✔️ 1 💤 0
100 runs  98 ✔️ 2 💤 0

Results for commit 12b34f3.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr merged commit 9be5e32 into main Nov 12, 2022
@AlexanderSehr AlexanderSehr deleted the users/jpeasier/FixUpdateKubernetesVersionOnNodePool branch November 12, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working [cat] modules category: modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants