Skip to content

[Modules] Fixing linter warning "decompiler-cleanup"#2329

Merged
AlexanderSehr merged 2 commits intomainfrom
users/krbar/2293-decompiler-cleanup
Nov 17, 2022
Merged

[Modules] Fixing linter warning "decompiler-cleanup"#2329
AlexanderSehr merged 2 commits intomainfrom
users/krbar/2293-decompiler-cleanup

Conversation

@krbar
Copy link
Copy Markdown
Contributor

@krbar krbar commented Nov 13, 2022

Description

The PR addresses the issue #2293 and renames all variables which cause the linter warning decompiler-cleanup.
All variables with names ending with _var were renamed to end with Var, for example:
old: identity_var
new: identityVar

Pipeline references

Following modules have been changed:

Authorization: PolicyAssignments

Authorization: RoleAssignments

Automation: AutomationAccounts

DataFactory: Factories

Databricks: Workspaces

EventHub: Namespaces

Network: AzureFirewalls

Network: BastionHosts

Network: Connections

Network: LoadBalancers

Network: NatGateways

Network: VirtualNetworkGateways

Network: VirtualNetworks

Service Fabric: Clusters

VirtualMachineImages: ImageTemplates

Type of Change

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@krbar krbar marked this pull request as ready for review November 13, 2022 22:01
@krbar krbar requested a review from a team as a code owner November 13, 2022 22:01
@krbar krbar changed the title [Modules] Fixing linter warning decompiler-cleanup [Modules] Fixing linter warning "decompiler-cleanup" Nov 13, 2022
@AlexanderSehr AlexanderSehr merged commit 1f046fa into main Nov 17, 2022
@AlexanderSehr AlexanderSehr deleted the users/krbar/2293-decompiler-cleanup branch November 17, 2022 19:17
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: New Linter warning decompiler-cleanup should be addressed

2 participants