Skip to content

[Utilities] Fix for test name prefix availability#2330

Merged
AlexanderSehr merged 16 commits intomainfrom
users/fblix/fixForTest-NamePrefixAvailability
Nov 29, 2022
Merged

[Utilities] Fix for test name prefix availability#2330
AlexanderSehr merged 16 commits intomainfrom
users/fblix/fixForTest-NamePrefixAvailability

Conversation

@fblix
Copy link
Copy Markdown
Contributor

@fblix fblix commented Nov 14, 2022

Description

Thank you for your contribution !

This PR includes updates to the Test-NamePrefixAvailability script. (as per #2242)
Changes were necessary since there are no more parameter.json files but bicep files used for parameter testing.
A pipeline run is not attached since the script is to be run locally (see "Getting started" section in the wiki).

Happy to discuss my approach :)

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
N/A

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@fblix fblix marked this pull request as ready for review November 14, 2022 10:23
@fblix fblix requested a review from a team as a code owner November 14, 2022 10:23
Comment thread utilities/tools/Test-NamePrefixAvailability.ps1 Outdated
@AlexanderSehr AlexanderSehr changed the title Users/fblix/fix for test name prefix availability [Modules] Update for test name prefix availability Nov 14, 2022
@eriqua eriqua changed the title [Modules] Update for test name prefix availability [Utilities] Fix for test name prefix availability Nov 14, 2022
@eriqua eriqua added enhancement New feature or request [cat] utilities category: utilities labels Nov 14, 2022
@fblix fblix requested a review from eriqua November 16, 2022 23:10
Comment thread utilities/tools/Test-NamePrefixAvailability.ps1 Outdated
Comment thread utilities/tools/Test-NamePrefixAvailability.ps1 Outdated
Comment thread utilities/tools/Test-NamePrefixAvailability.ps1 Outdated
@fblix fblix requested a review from AlexanderSehr November 17, 2022 23:03
Comment thread utilities/tools/Test-NamePrefixAvailability.ps1 Outdated
Comment thread utilities/tools/Test-NamePrefixAvailability.ps1 Outdated
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Comment thread utilities/tools/Test-NamePrefixAvailability.ps1 Outdated
Comment thread utilities/tools/Test-NamePrefixAvailability.ps1 Outdated
Comment thread utilities/tools/Test-NamePrefixAvailability.ps1
@JPEasier JPEasier self-assigned this Nov 24, 2022
Comment thread utilities/tools/Test-NamePrefixAvailability.ps1 Outdated
Comment thread utilities/tools/Test-NamePrefixAvailability.ps1 Outdated
@AlexanderSehr AlexanderSehr merged commit b94533d into main Nov 29, 2022
@AlexanderSehr AlexanderSehr deleted the users/fblix/fixForTest-NamePrefixAvailability branch November 29, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] utilities category: utilities enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report]: Test-NamePrefixAvailability not compatible with new dependencies approach

4 participants