[Modules] Replacing hardcoded environment URLs with the environment() function

[krbar]

Description

The PR resolves #2224 and replaces hardcoded environment URLs with the environment() function. In some cases these hardcoded URLs caused the linter warning "no hardcoded environment URL"

More about the environment function: https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/bicep-functions-deployment#environment

Following hardcoded env URLs have been identified and replaced:

• core.windows.net replaced with ${environment().suffixes.storage}
• .azurecr.io replaced with ${environment().suffixes.acrLoginServer}
• azurefd.net replaced with ${environment().suffixes.azureFrontDoorEndpointSuffix}

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

• Bugfix (non-breaking change which fixes an issue)

Checklist

• I'm sure there are no other open Pull Requests for the same update/change
• My corresponding pipelines / checks run clean and green without any errors or warnings
• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (readme)
• I did format my code

[github-actions]

Test Results

  1 files  ±    0    1 suites  ±0   37s ⏱️ - 5m 8s
61 tests  - 513  59 ✔️  - 505  2 💤  - 8  0 ❌ ±0 
88 runs   - 503  83 ✔️  - 496  5 💤  - 7  0 ❌ ±0 

Results for commit 2533195. ± Comparison against base commit d28cadd.

[github-actions]

Test Results

  1 files  ±    0    1 suites  ±0   29s ⏱️ - 5m 16s
60 tests  - 514  58 ✔️  - 506  2 💤  -   8  0 ❌ ±0 
60 runs   - 531  58 ✔️  - 521  2 💤  - 10  0 ❌ ±0 

Results for commit 2533195. ± Comparison against base commit d28cadd.

♻️ This comment has been updated with latest results.