Skip to content

[Modules] Improve disk encryption options to VM and VMSS#2366

Merged
eriqua merged 35 commits intomainfrom
users/erikag/2237-vm-des
Nov 25, 2022
Merged

[Modules] Improve disk encryption options to VM and VMSS#2366
eriqua merged 35 commits intomainfrom
users/erikag/2237-vm-des

Conversation

@eriqua
Copy link
Copy Markdown
Contributor

@eriqua eriqua commented Nov 25, 2022

Description

  • Remove enableServerSideEncryption parameter. SSE is by default with Platform Managed Keys (PMK) on VM disks. To configure SSE+CMK or SSE+CMK&PMK, a disk encryption set resource ID can be referenced as part of the creation of osDisks and dataDisks. This is aligning the approach for osDisk and dataDisks, addressing issue Difference between VM Disk CMK encryption for OS and Data disks #2237 and discussion Difference between VM Disk CMK encryption for OS and Data disks #2235
  • Update naming to align to the latest approach. Rename def to com for common tests, rename adp-* to dep-* for dependencies
  • Update references to the Disk Encryption extension to Azure Disk Encryption extension. Update extensionAzureDiskEncryptionConfig parameter description, specifying restrictions on the usage of the ADE extension when encryptionathost and SSE+CMK is in place.
  • Update parameter usage for osDisk and datatDisk on how to enable SSE+CMK.
  • Add note on restictions to osDisk, datatDisk and extensionAzureDiskEncryptionConfig parameter usage

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute: VirtualMachines
Compute: VirtualMachineScaleSets

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@eriqua eriqua linked an issue Nov 25, 2022 that may be closed by this pull request
@eriqua eriqua added enhancement New feature or request [cat] modules category: modules [cat] testing category: testing labels Nov 25, 2022
@eriqua eriqua added the documentation Improvements or additions to documentation label Nov 25, 2022
@eriqua eriqua marked this pull request as ready for review November 25, 2022 20:02
@eriqua eriqua requested a review from a team as a code owner November 25, 2022 20:02
@eriqua eriqua enabled auto-merge (squash) November 25, 2022 20:03
Comment thread .github/actions/templates/validateModulePester/action.yml
@eriqua eriqua merged commit 6a7169c into main Nov 25, 2022
@eriqua eriqua deleted the users/erikag/2237-vm-des branch November 25, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules category: modules [cat] testing category: testing documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Difference between VM Disk CMK encryption for OS and Data disks

2 participants