Skip to content

[Fixes] Fixes Role Assignment module tests #2390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexanderSehr merged 2 commits into from
Nov 29, 2022
Merged

[Fixes] Fixes Role Assignment module tests #2390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ebaec6
First commit
AlexanderSehr Nov 29, 2022
47b239a
Fixed test
AlexanderSehr Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/Microsoft.Authorization/roleAssignments/.test/mg.min/deploy.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,6 @@ module testDeployment '../../managementGroup/deploy.bicep' = {
enableDefaultTelemetry: enableDefaultTelemetry
principalId: resourceGroupResources.outputs.managedIdentityPrincipalId
roleDefinitionIdOrName: 'Storage Queue Data Reader'
principalType: 'ServicePrincipal'
}
}
1 change: 1 addition & 0 deletions modules/Microsoft.Authorization/roleAssignments/.test/rg.min/deploy.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ module testDeployment '../../resourceGroup/deploy.bicep' = {
enableDefaultTelemetry: enableDefaultTelemetry
principalId: resourceGroupResources.outputs.managedIdentityPrincipalId
roleDefinitionIdOrName: 'Storage Queue Data Reader'
principalType: 'ServicePrincipal'
resourceGroupName: resourceGroup.name
subscriptionId: subscription().subscriptionId
}
Expand Down
1 change: 1 addition & 0 deletions modules/Microsoft.Authorization/roleAssignments/.test/sub.min/deploy.test.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ module testDeployment '../../subscription/deploy.bicep' = {
enableDefaultTelemetry: enableDefaultTelemetry
principalId: resourceGroupResources.outputs.managedIdentityPrincipalId
roleDefinitionIdOrName: 'Storage Queue Data Reader'
principalType: 'ServicePrincipal'
subscriptionId: subscription().subscriptionId
}
}
12 changes: 12 additions & 0 deletions modules/Microsoft.Authorization/roleAssignments/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ module roleAssignments './Microsoft.Authorization/roleAssignments/deploy.bicep'
roleDefinitionIdOrName: 'Storage Queue Data Reader'
// Non-required parameters
enableDefaultTelemetry: '<enableDefaultTelemetry>'
principalType: 'ServicePrincipal'
}
}
```
Expand All @@ -281,6 +282,9 @@ module roleAssignments './Microsoft.Authorization/roleAssignments/deploy.bicep'
// Non-required parameters
"enableDefaultTelemetry": {
"value": "<enableDefaultTelemetry>"
},
"principalType": {
"value": "ServicePrincipal"
}
}
}
Expand Down Expand Up @@ -369,6 +373,7 @@ module roleAssignments './Microsoft.Authorization/roleAssignments/deploy.bicep'
roleDefinitionIdOrName: 'Storage Queue Data Reader'
// Non-required parameters
enableDefaultTelemetry: '<enableDefaultTelemetry>'
principalType: 'ServicePrincipal'
resourceGroupName: '<resourceGroupName>'
subscriptionId: '<subscriptionId>'
}
Expand Down Expand Up @@ -398,6 +403,9 @@ module roleAssignments './Microsoft.Authorization/roleAssignments/deploy.bicep'
"enableDefaultTelemetry": {
"value": "<enableDefaultTelemetry>"
},
"principalType": {
"value": "ServicePrincipal"
},
"resourceGroupName": {
"value": "<resourceGroupName>"
},
Expand Down Expand Up @@ -487,6 +495,7 @@ module roleAssignments './Microsoft.Authorization/roleAssignments/deploy.bicep'
roleDefinitionIdOrName: 'Storage Queue Data Reader'
// Non-required parameters
enableDefaultTelemetry: '<enableDefaultTelemetry>'
principalType: 'ServicePrincipal'
subscriptionId: '<subscriptionId>'
}
}
Expand Down Expand Up @@ -515,6 +524,9 @@ module roleAssignments './Microsoft.Authorization/roleAssignments/deploy.bicep'
"enableDefaultTelemetry": {
"value": "<enableDefaultTelemetry>"
},
"principalType": {
"value": "ServicePrincipal"
},
"subscriptionId": {
"value": "<subscriptionId>"
}
Expand Down