-
Notifications
You must be signed in to change notification settings - Fork 436
[Modules] Updated App Service Environments to latest API Version (2022-03-01) #2639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
a52dc13
updated ase api and tests
ahmadabdalla 03e0a9c
introduced custom dns settings
ahmadabdalla 5c536b0
test
ahmadabdalla f161f05
updated documentation
ahmadabdalla d8bf7b7
Merge remote-tracking branch 'origin/main' into users/ahmad/2622_AseV3
ahmadabdalla a236453
updated module
ahmadabdalla ce4af47
Merge remote-tracking branch 'origin/main' into users/ahmad/2622_AseV3
ahmadabdalla bc772d8
updated identity variable
ahmadabdalla ed01aa1
Merge remote-tracking branch 'origin/main' into users/ahmad/2622_AseV3
ahmadabdalla bbaa7ed
Merge remote-tracking branch 'origin/main' into users/ahmad/2622_AseV3
ahmadabdalla 475ddff
restored to appServiceEnvironment
ahmadabdalla ee4a9be
updated name prefix typo
ahmadabdalla 072f6ac
fixed namePrefix Typo
ahmadabdalla d18b0ff
fixed typo
ahmadabdalla eaa8187
reverted identity settings
ahmadabdalla e8450c5
restored identity change
ahmadabdalla 308cee7
case sensitive path
ahmadabdalla d450729
Merge remote-tracking branch 'origin/main' into users/ahmad/2622_AseV3
ahmadabdalla 162213c
update documentation
ahmadabdalla 036cefb
Updated custom dns suffix path
ahmadabdalla 3e9389a
Apply suggestions from code review
ahmadabdalla 2737a7b
updated documentation
ahmadabdalla 87ff5eb
Merge remote-tracking branch 'origin/main' into users/ahmad/2622_AseV3
ahmadabdalla 10ac55c
Merge remote-tracking branch 'origin/main' into users/ahmad/2622_AseV3
ahmadabdalla b8e0c09
Aligned to new shared scripts model
ahmadabdalla 94f2143
Merge remote-tracking branch 'origin/main' into users/ahmad/2622_AseV3
ahmadabdalla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
modules/Microsoft.Web/hostingEnvironments/configurations-customdnssuffix/deploy.bicep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| @description('Conditional. The name of the parent Hosting Environment. Required if the template is used in a standalone deployment.') | ||
| param hostingEnvironmentName string | ||
|
|
||
| @description('Required. Enable the default custom domain suffix to use for all sites deployed on the ASE.') | ||
| param dnsSuffix string | ||
|
|
||
| @description('Required. The URL referencing the Azure Key Vault certificate secret that should be used as the default SSL/TLS certificate for sites with the custom domain suffix.') | ||
| param certificateUrl string | ||
|
|
||
| @description('Required. The user-assigned identity to use for resolving the key vault certificate reference. If not specified, the system-assigned ASE identity will be used if available.') | ||
| param keyVaultReferenceIdentity string | ||
|
|
||
| @description('Optional. Enable telemetry via a Globally Unique Identifier (GUID).') | ||
| param enableDefaultTelemetry bool = true | ||
|
|
||
| resource defaultTelemetry 'Microsoft.Resources/deployments@2021-04-01' = if (enableDefaultTelemetry) { | ||
| name: 'pid-47ed15a6-730a-4827-bcb4-0fd963ffbd82-${uniqueString(deployment().name)}' | ||
| properties: { | ||
| mode: 'Incremental' | ||
| template: { | ||
| '$schema': 'https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#' | ||
| contentVersion: '1.0.0.0' | ||
| resources: [] | ||
| } | ||
| } | ||
| } | ||
|
|
||
| resource appServiceEnvironment 'Microsoft.Web/hostingEnvironments@2022-03-01' existing = { | ||
| name: hostingEnvironmentName | ||
| } | ||
|
|
||
| resource configuration 'Microsoft.Web/hostingEnvironments/configurations@2022-03-01' = { | ||
| name: 'customdnssuffix' | ||
| parent: appServiceEnvironment | ||
| properties: { | ||
| certificateUrl: certificateUrl | ||
| keyVaultReferenceIdentity: keyVaultReferenceIdentity | ||
| dnsSuffix: dnsSuffix | ||
| } | ||
| } | ||
|
|
||
| @description('The name of the configuration.') | ||
| output name string = configuration.name | ||
|
|
||
| @description('The resource ID of the deployed configuration.') | ||
| output resourceId string = configuration.id | ||
|
|
||
| @description('The resource group of the deployed configuration.') | ||
| output resourceGroupName string = resourceGroup().name | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.