[Modules] Add Synapse Workspace module#928
Merged
Merged
Conversation
* Added support for Synapse Private Link Hubs * Fixed typo in Github workflow * Create new workflow for deploying Synapse Private Link Hub * Added support for Locks, RBAC and Private Endpoints * Updated ReadMe file * Fixed outputs & updated ReadMe * Switched back to main branch Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.Synapse/privateLinkHubs/.bicep/nested_rbac.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.Synapse/privateLinkHubs/.bicep/nested_rbac.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.Synapse/privateLinkHubs/readme.md Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.Synapse/privateLinkHubs/readme.md Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.Synapse/privateLinkHubs/readme.md Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Update arm/Microsoft.Synapse/privateLinkHubs/readme.md Co-authored-by: Alexander Sehr <ASehr@hotmail.de> * Fixed naming, added ADO pipeline, updated README * Removed TODOs in ReadMe * Reversed changes in auto-generated Readme to avoid conflicts * Remove lock settings from parameter file * Updated based on comments * Updated readme.md * Initial commit for Synapse Workspace module * Fixed failed Pester tests * Fixes for failed Pester tests * Fix: Workspace cannot be created with only UserAssigned identity. * The default data lake storage account url property should be in the format: https://accountname.dfs.core.windows.net * Added Diagnostics settings and additional set of parameters * Add param file to pipeline * Updated readme file * Added test cases for encryption configuration * Added test case for managed vnet * Updated workspace name to be unique * Removed unsupported setting - AzureADOnlyAuth * Added ADO pipeline for Synapse Workspace module * Created unique names * Updated resource names, switched from name to resource id for storage account * Parameter file should not contain the Subscription ID guid * Changed from resource id to name for default storage account, provided tenant id instead of tenant name * Updated param reference to Key Vault keys * Fixed diagnostics account id * Switched GitHub Workflow to trigger on main branch * Removed fetch from upstream repo * Switched back to trigger on current branch for testing * Switched back to trigger on current branch for testing * Added missing UAI to parameters file * Updated process for MSI encryption * Fixed Pester errors * Fixed deployment errors * Deployment fixes * Deployment fixes * Deployment fixes * Deployment fixes * Deployment fixes * Slim down the tests * Deployment fixes * Deployment fixes * Deployment fixes 1 * Deployment fixes 2 * Removed testing deployment configuration * Removed unused code blocks * Fixed Linter issues * Updated README * Added support for Encryption Key Vault with Access Policies * Trigger on branch to test before merge * Trigger GH action * Added all validation steps * Updated README * Trigger workflow * Removed changes * Revert "Removed changes" This reverts commit 8cf78a0. * Revert "Added all validation steps" This reverts commit 8f95b10. * Revert "Updated README" This reverts commit a0b4c49. * Fixing weird issues * Updated messsages from Test function * Fixed missing if condition * Removed scope fro RBAC assignment * Removed table formatting * Added missing parent to access policy * Resolved code formatting issues * Updated README * Moved to dependency keyvault Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
AlexanderSehr
added
[cat] modules
Unit Test Results 1 files ± 0 1 suites ±0 15s ⏱️ -27s Results for commit c65cedf. ± Comparison against base commit 80087b3. This pull request removes 30 and adds 11 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
eriqua
reviewed
Jul 18, 2022
eriqua
reviewed
Jul 18, 2022
eriqua
reviewed
Jul 18, 2022
eriqua
reviewed
Jul 18, 2022
eriqua
reviewed
Jul 18, 2022
eriqua
reviewed
Jul 18, 2022
eriqua
reviewed
Jul 18, 2022
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
eriqua
dismissed stale reviews from AlexanderSehr and MariusStorhaug
All comments addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Add support for deploying Synapse Workspace. The PR implements basic configuration and more advanced configuration will come in future PRs.
Pipeline reference
Dependencies
Type of Change
Checklist