Skip to content

feat: adding child platform management groups#67

Merged
jaredfholgate merged 5 commits into
mainfrom
feature-add-platform-child-mg-groups
Jan 23, 2025
Merged

feat: adding child platform management groups#67
jaredfholgate merged 5 commits into
mainfrom
feature-add-platform-child-mg-groups

Conversation

@sdeguchi
Copy link
Copy Markdown
Contributor

@sdeguchi sdeguchi commented Jan 23, 2025

Overview/Summary

Adding platform/landingzone child management groups to architecture definition file.

This PR fixes/adds/changes/removes

  1. Adds platform/landingzone child management groups to architecture definition file.
  2. Changes architecture definition creation to use json objects
  3. Adds templating for management groups IDs
  4. Removes old architecture definition template file
  5. Adds new architecture definition template file

Breaking Changes

  1. Old architecture definition template file is no longer supported.

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@sdeguchi sdeguchi requested a review from a team January 23, 2025 02:26
@sdeguchi sdeguchi force-pushed the feature-add-platform-child-mg-groups branch from 6b28956 to d94390d Compare January 23, 2025 02:56
jaredfholgate
jaredfholgate previously approved these changes Jan 23, 2025
Copy link
Copy Markdown
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice improvement. :)

@jaredfholgate jaredfholgate added the PR: Safe to test 🧪 Enables running of End to End Tests label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Safe to test 🧪 Enables running of End to End Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants