Skip to content

feat: support looking up github user by username#90

Merged
jaredfholgate merged 1 commit into
mainfrom
feat--support-looking-up-github-user-by-username
May 12, 2025
Merged

feat: support looking up github user by username#90
jaredfholgate merged 1 commit into
mainfrom
feat--support-looking-up-github-user-by-username

Conversation

@jaredfholgate
Copy link
Copy Markdown
Member

@jaredfholgate jaredfholgate commented May 12, 2025

Overview/Summary

Allow searching for GitHub users by username or email.

This PR fixes/adds/changes/removes

  1. Feature Request: allow searching for github users by username as well as email Azure-Landing-Zones#2398

Breaking Changes

None

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate self-assigned this May 12, 2025
@jaredfholgate jaredfholgate added the PR: Safe to test 🧪 Enables running of End to End Tests label May 12, 2025
@jaredfholgate jaredfholgate requested a review from Copilot May 12, 2025 16:20
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables the support for looking up GitHub users by username in addition to email, in order to provide more flexible approver identification.

  • Splits the input approvers into email-based and username-based lists.
  • Adjusts user selection and error messaging accordingly.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
modules/github/team.tf Updated logic to separate and validate approvers by email and login.
alz/github/variables.tf Updated variable description to reflect support for usernames.

Comment thread modules/github/team.tf
Comment thread modules/github/team.tf
@jaredfholgate jaredfholgate merged commit 3920708 into main May 12, 2025
39 checks passed
@jaredfholgate jaredfholgate deleted the feat--support-looking-up-github-user-by-username branch May 12, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Safe to test 🧪 Enables running of End to End Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants