feat: extend custom role definitions with additional permissions for …#92
Merged
jaredfholgate merged 1 commit intoMay 16, 2025
Merged
Conversation
…terraform (#91) * feat: extend custom role definitions with additional permissions for Azure resources to correct deployment failures using terraform * align permissions as per request * align permissions for all deployment tools
5 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR extends the custom role definitions for Terraform deployments by adding additional permissions to align with the bicep contributor role and resolve deployment failures.
- Added new permissions to write policy definitions, policy set definitions, policy assignments, role definitions, role assignments, and diagnostic settings
- Updated variables across alz/local, alz/github, and alz/azuredevops modules to support these changes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| alz/local/variables.tf | Extended the custom role with new policy and role write permissions |
| alz/github/variables.tf | Adjusted permission entries, reordering management group permissions |
| alz/azuredevops/variables.tf | Added new permissions for policy and role management |
jtracey93
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Azure resources to correct deployment failures using terraform
Overview/Summary
Currently the terraform alz_management_group_contributor role does not possess sufficient permissions to deploy custom roles and custom policies. This request aligns this role with the bicep contributor which does have the correct permissions as per 341
This PR fixes/adds/changes/removes
Resolves issues whereby the custom role for terraform apply does not contain sufficient permissions to create the roles and policies required by the accelerator
Breaking Changes
None
Testing Evidence
Giving the apply MI owner rights to the root management group allows the roles and policies to be created. Modifying the custom role with the bicep permissions also allows this to function correctly.
As part of this Pull Request I have
mainbranch