Skip to content

feat: support ghe.com in self hosted agent#93

Merged
jaredfholgate merged 4 commits into
mainfrom
feat-support-ghe-in-self-hosted-agent
May 27, 2025
Merged

feat: support ghe.com in self hosted agent#93
jaredfholgate merged 4 commits into
mainfrom
feat-support-ghe-in-self-hosted-agent

Conversation

@jaredfholgate
Copy link
Copy Markdown
Member

@jaredfholgate jaredfholgate commented May 27, 2025

Overview/Summary

Support for ghe.com in the upstream docker image for self hosted agents.

Associated dockerfile update: Azure/avm-container-images-cicd-agents-and-runners@bc4087f...39b9059#diff-8a2c08102e431cbbf7c60d7181dcfcbfe699b04661501da2cf8d24c16ce684bf

This PR fixes/adds/changes/removes

N/A

Breaking Changes

None

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate self-assigned this May 27, 2025
@jaredfholgate jaredfholgate added the PR: Safe to test 🧪 Enables running of End to End Tests label May 27, 2025
@jaredfholgate jaredfholgate requested a review from Copilot May 27, 2025 10:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for self-hosted agent container image defaults and updates paths.

  • Updates default container image repository URLs for GitHub runners and Azure DevOps agents
  • Bumps the default container image tags
  • Renames the default image folder paths to *-aci variants

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
alz/github/variables.tf Updated runner container image repository URL, tag, and folder defaults
alz/azuredevops/variables.tf Updated agent container image repository URL, tag, and folder defaults

Comment thread alz/github/variables.tf
Comment thread alz/azuredevops/variables.tf
@jaredfholgate
Copy link
Copy Markdown
Member Author

Successful e2e test run here: https://github.com/Azure/accelerator-bootstrap-modules/actions/runs/15273784826/job/42955229176?pr=93

Removed redundant debug code only in final commit, so didn't want to re-run the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Safe to test 🧪 Enables running of End to End Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants