Merged
Conversation
northtyphoon
requested review from
Wwwsylvia,
sajayantony and
shizhMSFT
as code owners
Wwwsylvia
reviewed
Apr 20, 2022
Contributor
Wwwsylvia
left a comment
Wwwsylvia
left a comment
There was a problem hiding this comment.
Which vulnerabilities are we addressing in this PR?
northtyphoon
force-pushed
the
update-dependency
branch
from
c3b0554 to
e9b78a2
Compare
update golangci to v1.45.2
northtyphoon
force-pushed
the
update-dependency
branch
from
e9b78a2 to
6d85d43
Compare
wangxiaoxuan273
approved these changes
Apr 29, 2022
Member
wangxiaoxuan273
left a comment
wangxiaoxuan273
left a comment
There was a problem hiding this comment.
LGTM. Tested on my Mac M1 and the build succeeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR