added one message at the beginning of dryRunPurge#106
Merged
northtyphoon merged 2 commits intoAzure:mainfrom Apr 29, 2022
wangxiaoxuan273:improve-dry-run-output
Merged
added one message at the beginning of dryRunPurge#106northtyphoon merged 2 commits intoAzure:mainfrom wangxiaoxuan273:improve-dry-run-output
northtyphoon merged 2 commits intoAzure:mainfrom
wangxiaoxuan273:improve-dry-run-output
Conversation
shizhMSFT
reviewed
Apr 28, 2022
Member
shizhMSFT
left a comment
There was a problem hiding this comment.
Instead of a claim at the very beginning, how about changing all the wordings for dry run?
For example,
- Tags to be deleted for repository: ...
- Number of tags to be deleted: ...
- Number of manifests to be deleted: ..
The above wording sounds less scary and can be distinguished from real purge easily.
Note: Lots of people read the logs from the bottom line to the top.
shizhMSFT
reviewed
Apr 28, 2022
shizhMSFT
approved these changes
Apr 29, 2022
Member
shizhMSFT
left a comment
There was a problem hiding this comment.
LGTM. It would be better to update the PR description with some tags / manifest to be deleted instead of 0s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
#107 Improved the output message in dry run mode. Added one message making clear that nothing will be deleted, and changed the wording for dry run output.
Output after the change: