Skip to content

Change confusing dry-run message#123

Merged
shizhMSFT merged 1 commit intoAzure:mainfrom
mherda64:improve-dry-run-output
Aug 31, 2022
Merged

Change confusing dry-run message#123
shizhMSFT merged 1 commit intoAzure:mainfrom
mherda64:improve-dry-run-output

Conversation

@mherda64
Copy link
Contributor

Purpose of the PR

  • Changed confusing message in acr purge with --dry-run flag set

I found it confusing that the acr purge command with --dry-run flag set informs me that the whole repositories would be deleted rather than tags in the repository if I used the command without the flag set. I believe that the message is now more informative and unambiguous.

Copy link
Member

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit a352a17 into Azure:main Aug 31, 2022
@shizhMSFT
Copy link
Member

Thank @mherda64 for contributing this fix. /cc @northtyphoon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants