Skip to content

fix: docker build with golang 1.22 + FIPS enabled #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
northtyphoon merged 4 commits into from
Jun 3, 2024
Merged

fix: docker build with golang 1.22 + FIPS enabled #298

northtyphoon merged 4 commits into from
Jun 3, 2024

Conversation

@northtyphoon
Copy link
Member

@northtyphoon northtyphoon commented May 31, 2024 •
edited
Loading

Purpose of the PR

  • enable cgo to work with golang 1.22 + FIPS enabled
  • add docker build in pr validation
  • update owner list

Fixes #261

@northtyphoon northtyphoon requested a review from sajayantony as a code owner May 31, 2024 23:04
wju-MSFT
wju-MSFT approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@wju-MSFT wju-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@northtyphoon northtyphoon merged commit 7c49b5c into Azure:main Jun 3, 2024
@northtyphoon northtyphoon mentioned this pull request Jun 3, 2024
Closed
@northtyphoon northtyphoon deleted the fix-build branch July 8, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

1 more reviewer

@wju-MSFT wju-MSFT wju-MSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docker Build fails

2 participants

@northtyphoon @wju-MSFT