Skip to content

Revert "fix: Foundry E2E quick-wins (#118)"#119

Merged
Dongbumlee merged 1 commit into
developfrom
revert/foundry-eval-quick-wins
Apr 29, 2026
Merged

Revert "fix: Foundry E2E quick-wins (#118)"#119
Dongbumlee merged 1 commit into
developfrom
revert/foundry-eval-quick-wins

Conversation

@Dongbumlee
Copy link
Copy Markdown
Collaborator

Reverts #118.

Why

PR #108 (AgentOps 1.0 revamp, feature/revamp-1.0main) supersedes most of #118 by deleting the systems #118 patched:

#118 fix What #108 does Outcome
#116 latency thresholds in 5 templates/bundles/*.yaml Deletes the entire templates/bundles/ directory Edits become orphaned
#115 agentops config validate -c <path> Removes the config sub-command entirely; new agentops eval run -c <path> already takes a config path Implementation superseded
#117 bundles.md / tutorial caveats Rewrites tutorial-conversational-agent.md and tutorial-agent-workflow.md end-to-end Edits get overwritten

Only the #111 agent_id versioning docs survive intact under the new schema. Rather than land partial fixes that mostly become merge churn for #108, we revert and re-scope.

Plan after this lands

  1. Wait for AgentOps 1.0 revamp — flat schema, MCP server, opt-in Foundry publish #108 to merge.
  2. Re-open Implement or hide 'agentops config validate' (currently a stub) #115 / Default avg_latency_seconds threshold (10s) is unrealistic for Foundry cloud eval #116 / agent_workflow_baseline silently scores ~0 against tool-less agents #117 against the 1.0 (flat agentops.yaml) schema — the defects still apply, just to different files.
  3. Re-apply Document agent_id resolution when version is omitted #111 (agent_id versioning) on top of the new tutorial — docs are the same on the revamp branch.

Validation

python3 -m pytest tests/ -x -q → 282 passed (baseline restored).

Branches retained

This reverts merge commit 72b457e (PR #118).

PR #108 (AgentOps 1.0 revamp) supersedes most of these fixes:
- bundle templates that #118 modified are deleted under 1.0
- the `config validate` command #118 implemented is removed in 1.0
- the conversational/agent-workflow tutorial sections that #118 edited are
  rewritten end-to-end in #108

Only the agent_id versioning docs (issue #111) survive intact under the new
schema. Re-opening #115/#116/#117 against the 1.0 schema is the right path;
landing #118 first creates merge churn for #108 and leaves stale docs in tree.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant