Skip to content

frontend: Fix register AKS cluster heading#233

Merged
sniok merged 1 commit into
Azure:mainfrom
vyncent-t:fix-aks-register-heading
Feb 11, 2026
Merged

frontend: Fix register AKS cluster heading#233
sniok merged 1 commit into
Azure:mainfrom
vyncent-t:fix-aks-register-heading

Conversation

@vyncent-t
Copy link
Copy Markdown
Collaborator

@vyncent-t vyncent-t commented Feb 9, 2026

Description

This PR fixes an a11y issue identified by Lighthouse where headings were not in sequential order for the "Register AKS cluster" modal.

The title component was visually styled as an h6 header with no larger headers present on the screen. This caused Lighthouse to flag improper heading hierarchy which can negatively impact screen reader navigation.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Performance improvement
  • Code refactoring

Related Issues

Closes #193
Related to #219

Changes Made

  • Reformatted header component to have the HTML match the visual styling

How to test:

  • Click on your username on the side bar in AKS
  • Continue beyond the login modal
  • View the "Register AKS Cluster" modal
  • Use inspect tools and open Lighthouse
  • Scan at this view
  • Notice full checklist is valid

Images

image

@vyncent-t vyncent-t self-assigned this Feb 9, 2026
Copilot AI review requested due to automatic review settings February 9, 2026 20:18
@vyncent-t vyncent-t marked this pull request as draft February 9, 2026 20:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to resolve a Lighthouse accessibility finding in the “Register AKS Cluster” modal by correcting the semantic heading hierarchy to better match the visual styling and improve screen reader navigation.

Changes:

  • Updated the modal title markup to adjust the rendered heading element for “Register AKS Cluster”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugins/aks-desktop/src/components/AKS/RegisterAKSClusterDialog.tsx Outdated
@vyncent-t vyncent-t added the a11y a11y related issues label Feb 9, 2026
@vyncent-t vyncent-t force-pushed the fix-aks-register-heading branch from 8513bb2 to 2d316bf Compare February 9, 2026 20:54
@vyncent-t vyncent-t marked this pull request as ready for review February 9, 2026 20:57
Copilot AI review requested due to automatic review settings February 9, 2026 20:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugins/aks-desktop/src/components/AKS/RegisterAKSClusterDialog.tsx Outdated
@vyncent-t vyncent-t force-pushed the fix-aks-register-heading branch from 2d316bf to db756ca Compare February 9, 2026 21:06
Comment thread plugins/aks-desktop/src/components/AKS/RegisterAKSClusterDialog.tsx Outdated
Comment thread plugins/aks-desktop/src/components/AKS/RegisterAKSClusterDialog.tsx Outdated
Signed-off-by: Vincent T <vtaylor@microsoft.com>
Copilot AI review requested due to automatic review settings February 11, 2026 18:35
@vyncent-t vyncent-t force-pushed the fix-aks-register-heading branch from db756ca to 8dd2d69 Compare February 11, 2026 18:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sniok sniok merged commit 72803f3 into Azure:main Feb 11, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y a11y related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Register AKS Cluster (Heading elements are not in a sequentially-descending order)

3 participants