Skip to content

CreateAKSProject: Fix keyboard navigation #352

Merged
illume merged 2 commits into
Azure:mainfrom
sniok:a11y-create-project-fixes
Mar 3, 2026
Merged

CreateAKSProject: Fix keyboard navigation #352
illume merged 2 commits into
Azure:mainfrom
sniok:a11y-create-project-fixes

Conversation

@sniok
Copy link
Copy Markdown
Collaborator

@sniok sniok commented Mar 2, 2026

Fixes #304


Steps to test:

  • Launch the AKS desktop application and login with your v-id.
  • TAB to "Home" page.
  • Tab to "Projects" tab and press ENTER. Verify all the elements of "Projects" tab.
  • TAB to "Create Project" button and press ENTER. "Create a Project" dialog will open. Verify the dialog.
  • TAB to "AKS Managed Project" button and press ENTER.
  • "New Project" page will open.
  • TAB to Basics" page and fill all required info. TAB to "Next" button and press ENTER.
  • Observe that keyboard focus order resets to top navigation after navigating Back / Next instead of landing on first interactive control of the page.

Similar issue is also observed throughout the New Project page.

  • After activating the "Add Assignee" button the keyboard focus moves to the top navigation instead of assignee edit button in access step.

Copilot AI review requested due to automatic review settings March 2, 2026 19:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves keyboard accessibility in the AKS project creation flow by ensuring focus moves to the appropriate content when navigating between steps and when dynamically adding assignee fields.

Changes:

  • Add support for passing an inputRef through the reusable FormField component.
  • Auto-focus the newly added assignee email field in the Access step.
  • Auto-focus the first focusable control in the current step when activeStep changes.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
plugins/aks-desktop/src/components/CreateAKSProject/types.ts Extends FormFieldProps with inputRef for focus management.
plugins/aks-desktop/src/components/CreateAKSProject/components/FormField.tsx Wires inputRef through to the underlying MUI TextField.
plugins/aks-desktop/src/components/CreateAKSProject/components/AccessStep.tsx Focuses the newest assignee field after it’s added.
plugins/aks-desktop/src/components/CreateAKSProject/CreateAKSProject.tsx Attempts to focus the first interactive element on step navigation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugins/aks-desktop/src/components/CreateAKSProject/types.ts
Comment thread plugins/aks-desktop/src/components/CreateAKSProject/types.ts
@illume illume added p0 Highest priority a11y a11y related issues bug Something isn't working labels Mar 3, 2026
Copy link
Copy Markdown
Collaborator

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks!

@illume illume merged commit e1c35ea into Azure:main Mar 3, 2026
11 checks passed
@illume illume mentioned this pull request Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y a11y related issues bug Something isn't working p0 Highest priority

Projects

None yet

4 participants