CreateAKSProject: Fix keyboard navigation #352
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves keyboard accessibility in the AKS project creation flow by ensuring focus moves to the appropriate content when navigating between steps and when dynamically adding assignee fields.
Changes:
- Add support for passing an
inputRefthrough the reusableFormFieldcomponent. - Auto-focus the newly added assignee email field in the Access step.
- Auto-focus the first focusable control in the current step when
activeStepchanges.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| plugins/aks-desktop/src/components/CreateAKSProject/types.ts | Extends FormFieldProps with inputRef for focus management. |
| plugins/aks-desktop/src/components/CreateAKSProject/components/FormField.tsx | Wires inputRef through to the underlying MUI TextField. |
| plugins/aks-desktop/src/components/CreateAKSProject/components/AccessStep.tsx | Focuses the newest assignee field after it’s added. |
| plugins/aks-desktop/src/components/CreateAKSProject/CreateAKSProject.tsx | Attempts to focus the first interactive element on step navigation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304
Steps to test:
Similar issue is also observed throughout the New Project page.