GithubPipeline: ConfigurePipeline: Consolidate pipeline wizard review steps

[gambtho]

Summary

• Consolidate the 5-step pipeline wizard (Connect Source > Configure > Setup PR > Agent > Complete) into 3 steps (Connect Source > Set up Copilot Agent > Review & Merge) based on UX team feedback
• The "Review & Merge" step shows a vertical timeline with all three sub-phases (Setup PR, Copilot Agent, Deployment PR) in a single view with "Up next" sections for upcoming steps
• Replace close (X) button with collapse (>>) icon to encourage saving progress
• Replace "Start over" with "Cancel" as a tertiary CTA in the footer
• Add "View deployment" button on completion screen that navigates to the Deploy tab via setSelectedTab prop

Type of Change

• New feature (non-breaking change which adds functionality)
• Code refactoring

Related PRs

Depends on #406 (headlamp: pass setSelectedTab to header action components)

Changes Made

• ReviewAndMergeStep.tsx (new) — Composite component showing a vertical timeline with completed items summary, active section with PR/agent details, and upcoming phase previews
• WizardShell.tsx — 5 steps → 3 steps, renamed "Configure" to "Set up Copilot Agent", close X → collapse >>, "Start over" → "Cancel" moved to right side of footer
• getWizardStep.ts — Updated state-to-step mapping: Setup PR, Agent, Generated PR, and completion states all map to step 2 (Review & Merge)
• GitHubPipelineWizard.tsx — All review/merge/complete states now render ReviewAndMergeStep; added onViewDeployment prop; removed unused DeploymentStatusScreen/PRStatusScreen rendering and related variables
• ConfigurePipelineButton.tsx — Accepts setSelectedTab prop from Headlamp, passes onViewDeployment handler that closes the drawer and calls setSelectedTab('deploy')
• constants.ts — Removed NAVIGATE_TO_DEPLOY_TAB_EVENT constant (replaced by prop-based approach)
• getWizardStep.test.ts — Updated test expectations for the new 3-step mapping

Testing

• Unit tests pass (167 pipeline tests)
• TypeScript type check passes
• ESLint passes
• Prettier format check passes

Test Cases

1. Wizard stepper shows 3 steps with correct labels
2. Review & Merge step shows completed items as green checkmarks, active section with details, and upcoming phases as grayed "Up next"
3. Collapse (>>) button closes the drawer, progress persists on reopen
4. Cancel button shows discard confirmation dialog
5. "View deployment" button on completion screen closes drawer and navigates to Deploy tab

Closes

• Pipeline wizard UX: consolidate review steps into single tab #408

[Copilot]

Pull request overview

This PR streamlines the AKS Desktop GitHub Pipeline wizard UX by consolidating the pipeline flow into a 3-step wizard and introducing a unified “Review & Merge” experience across PR/agent/deploy states.

Changes:

• Collapse the wizard step model from 5 steps to 3, updating step mapping and tests.
• Replace multiple intermediate status screens with a single consolidated ReviewAndMergeStep.
• Add a new custom event + CTA plumbing intended to navigate users to the Deploy tab after pipeline configuration.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
plugins/aks-desktop/src/components/GitHubPipeline/utils/getWizardStep.ts	Updates state→wizard-step mapping to a 3-step model.
plugins/aks-desktop/src/components/GitHubPipeline/utils/getWizardStep.test.ts	Updates unit tests to match the new 3-step mapping.
plugins/aks-desktop/src/components/GitHubPipeline/constants.ts	Adds a new DOM event constant for “navigate to deploy tab”.
plugins/aks-desktop/src/components/GitHubPipeline/components/WizardShell.tsx	Updates step labels/types and adjusts header/footer UX (collapse, cancel).
plugins/aks-desktop/src/components/GitHubPipeline/components/ReviewAndMergeStep.tsx	New consolidated UI for setup PR / agent progress / deployment PR / completion.
plugins/aks-desktop/src/components/GitHubPipeline/GitHubPipelineWizard.tsx	Switches review/merge-related states to render ReviewAndMergeStep and adds onViewDeployment.
plugins/aks-desktop/src/components/ConfigurePipeline/ConfigurePipelineButton.tsx	Wires onViewDeployment to close the drawer + dispatch a navigation event.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[illume]

Thanks.

Can you please address the open comments? There's a CI failure.

[Copilot]

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 9 comments.

Comments suppressed due to low confidence (1)

plugins/aks-desktop/src/components/GitHubPipeline/components/ReviewAndMergeStep.tsx:1

• This new UI introduces many user-facing strings (including elapsed time text) as hard-coded English. Elsewhere in this plugin the wizard uses useTranslation() and translation JSON keys; please switch these strings to t(...) and add the corresponding keys to locale files to avoid an i18n regression.

// Copyright (c) Microsoft Corporation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (2)

plugins/aks-desktop/src/components/GitHubPipeline/utils/agentTemplates.ts:1

• Requiring manifests to include aks-project/pipeline-workflow: ${{ github.workflow }} is likely incorrect because GitHub Actions expressions are not evaluated inside static Kubernetes YAML; this would be applied literally unless an explicit templating/substitution step exists. Since you already annotate deployments at runtime via kubectl annotate ... aks-project/pipeline-workflow=${{ github.workflow }}, consider removing the manifest MUST requirement (or clarifying it will be overwritten), and rely on the runtime annotation step for the actual workflow name.
  plugins/aks-desktop/src/components/GitHubPipeline/utils/getWizardStep.ts:1
• This grouping is correct, but it’s easy to misread as missing returns for several cases (especially since this function previously returned different step indices per phase). Consider adding a short comment indicating that all of these states intentionally map to step 2 ('Review & Merge') to reduce future refactor risk.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

Pull request overview

Copilot reviewed 37 out of 37 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[gambtho]

fixing copilot comments and merge conflcits

[Copilot]

Pull request overview

Copilot reviewed 38 out of 38 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (2)

plugins/aks-desktop/src/components/GitHubPipeline/utils/getWizardStep.ts:1

• This switch relies on intentional fallthrough (multiple case labels with a single return 2), which is correct but easy to break during future edits (e.g., inserting logic between labels). Consider making each group explicitly return 2 (or adding a clarifying comment like // fallthrough: all map to step 2) to prevent accidental regressions.
  plugins/aks-desktop/src/components/GitHubPipeline/utils/agentTemplates.ts:1
• The instruction text says it annotates each Deployment with the run URL, but the command now also adds a aks-project/pipeline-workflow annotation. Update the surrounding instruction text to mention both annotations (run URL + workflow) so the generated guidance matches the actual command.

// Copyright (c) Microsoft Corporation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[illume]

@gambtho I read through the code, and it looks good to me.

It just needs the rebase against main to fix the git conflicts.

[Copilot]

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[illume]

These last changes look fine to me too.

[illume]

Thanks! 🎉

[Copilot]

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.