i18n: Update translations#411
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates localization assets and the localization distribution workflow so AKS Desktop and frontend translation artifacts stay current and OneLocBuild distribution preserves previously-existing keys.
Changes:
- Adjust
Localize/translation-manager.mjsdistribution to merge into existing locale JSON instead of replacing it. - Refresh AKS Desktop plugin locale files across multiple languages with newly collected/updated keys.
- Add/collect additional
Localize/locales/*artifacts (e.g.,frontend-app.json,frontend-glossary.json) and update Englishfrontend-translation.json.
Reviewed changes
Copilot reviewed 49 out of 94 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/aks-desktop/locales/zh-Hant/translation.json | Refresh plugin locale keys (zh-Hant) to match latest collected strings. |
| plugins/aks-desktop/locales/zh-Hans/translation.json | Refresh plugin locale keys (zh-Hans) to match latest collected strings. |
| plugins/aks-desktop/locales/tr/translation.json | Refresh plugin locale keys (tr) to match latest collected strings. |
| plugins/aks-desktop/locales/sv/translation.json | Refresh plugin locale keys (sv) to match latest collected strings. |
| plugins/aks-desktop/locales/ru/translation.json | Refresh plugin locale keys (ru) to match latest collected strings. |
| plugins/aks-desktop/locales/pt-PT/translation.json | Refresh plugin locale keys (pt-PT) to match latest collected strings. |
| plugins/aks-desktop/locales/pt-BR/translation.json | Refresh plugin locale keys (pt-BR) to match latest collected strings. |
| plugins/aks-desktop/locales/pl/translation.json | Refresh plugin locale keys (pl) to match latest collected strings. |
| plugins/aks-desktop/locales/nl/translation.json | Refresh plugin locale keys (nl) to match latest collected strings. |
| plugins/aks-desktop/locales/ko/translation.json | Refresh plugin locale keys (ko) to match latest collected strings. |
| plugins/aks-desktop/locales/ja/translation.json | Refresh plugin locale keys (ja) to match latest collected strings. |
| plugins/aks-desktop/locales/it/translation.json | Refresh plugin locale keys (it) to match latest collected strings. |
| plugins/aks-desktop/locales/id/translation.json | Refresh plugin locale keys (id) to match latest collected strings. |
| plugins/aks-desktop/locales/hu/translation.json | Refresh plugin locale keys (hu) to match latest collected strings. |
| plugins/aks-desktop/locales/fr/translation.json | Refresh plugin locale keys (fr) to match latest collected strings. |
| plugins/aks-desktop/locales/es/translation.json | Refresh plugin locale keys (es) to match latest collected strings. |
| plugins/aks-desktop/locales/de/translation.json | Refresh plugin locale keys (de) to match latest collected strings. |
| plugins/aks-desktop/locales/cs/translation.json | Refresh plugin locale keys (cs) to match latest collected strings. |
| Localize/translation-manager.mjs | Change distribution to preserve/merge existing keys when writing locale files. |
| Localize/locales/zh-Hant/frontend-app.json | Add collected frontend “app” namespace strings for zh-Hant. |
| Localize/locales/zh-Hans/frontend-glossary.json | Add collected frontend glossary strings for zh-Hans. |
| Localize/locales/zh-Hans/frontend-app.json | Add collected frontend “app” namespace strings for zh-Hans. |
| Localize/locales/tr/frontend-app.json | Add collected frontend “app” namespace strings for tr. |
| Localize/locales/sv/frontend-app.json | Add collected frontend “app” namespace strings for sv. |
| Localize/locales/ru/frontend-app.json | Add collected frontend “app” namespace strings for ru. |
| Localize/locales/pt-PT/frontend-app.json | Add collected frontend “app” namespace strings for pt-PT. |
| Localize/locales/pt-BR/frontend-app.json | Add collected frontend “app” namespace strings for pt-BR. |
| Localize/locales/pl/frontend-app.json | Add collected frontend “app” namespace strings for pl. |
| Localize/locales/nl/frontend-app.json | Add collected frontend “app” namespace strings for nl. |
| Localize/locales/ko/frontend-app.json | Add collected frontend “app” namespace strings for ko. |
| Localize/locales/ja/frontend-app.json | Add collected frontend “app” namespace strings for ja. |
| Localize/locales/it/frontend-app.json | Add collected frontend “app” namespace strings for it. |
| Localize/locales/id/frontend-glossary.json | Add collected frontend glossary strings for id. |
| Localize/locales/id/frontend-app.json | Add collected frontend “app” namespace strings for id. |
| Localize/locales/hu/frontend-app.json | Add collected frontend “app” namespace strings for hu. |
| Localize/locales/fr/frontend-app.json | Add collected frontend “app” namespace strings for fr. |
| Localize/locales/es/frontend-app.json | Add collected frontend “app” namespace strings for es. |
| Localize/locales/de/frontend-app.json | Add collected frontend “app” namespace strings for de. |
| Localize/locales/cs/frontend-app.json | Add collected frontend “app” namespace strings for cs. |
| Localize/locales/en/frontend-translation.json | Update collected English frontend translation keys for OneLocBuild. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Oh, I merged the other PR in. Can you please remove that first commit? |
aacee53 to
a05da15
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run i18nin the plugins/aks-dekstop/, they were outdatedHow to test:
npm run i18nin plugins/aks-desktop and make sure it's up to datenpm run i18n:collectin root folder to make sure all translations are collected properlyTodo:
I'll add a i18n check to CI for plguins/aks-dekstop in a future PR