aksd: Remove translation function from effect dependencies#441
Merged
Conversation
yolossn
approved these changes
Mar 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an infinite re-fetch / re-effect loop caused by including the i18n translation function t in React hook dependency arrays, where t appears to change identity between renders in some screens (e.g., project details).
Changes:
- Removed
tfrom auseEffectdependency array in the Scaling deployments watcher hook. - Removed
tfrom auseCallbackdependency array used to fetch GitHub repos. - Removed
tfrom the elapsed-time interval effect dependencies in the PR status screen.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| plugins/aks-desktop/src/components/Scaling/hooks/useDeployments.ts | Stops the deployments watcher effect from being re-created due to t changes. |
| plugins/aks-desktop/src/components/GitHubPipeline/components/RepoSelector.tsx | Prevents repo-fetch callback/effect from re-triggering due to t changes. |
| plugins/aks-desktop/src/components/GitHubPipeline/components/PRStatusScreen.tsx | Prevents the elapsed-time interval effect from restarting due to t changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
illume
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tfunction is recreated every render that causes effects that included it in the dependencies to loophow to test: