Skip to content

aksd: fix: AKS project overview cards disappear when plugin config is not initialized.#464

Merged
illume merged 1 commit into
Azure:mainfrom
tejhan:aksprojectsenablementfix
Mar 17, 2026
Merged

aksd: fix: AKS project overview cards disappear when plugin config is not initialized.#464
illume merged 1 commit into
Azure:mainfrom
tejhan:aksprojectsenablementfix

Conversation

@tejhan
Copy link
Copy Markdown
Collaborator

@tejhan tejhan commented Mar 17, 2026

Noticed when testing latest builds that the overview cards weren't rendering (Scaling, Metrics, Cluster Capabilities). I traced it to the 'Enable Github Pipelines' plugin setting. If you've never toggled it, the plugin config is uninitialized, which propagates in an error when registering the project since isEnabled ends up receiving an undefined value.

To fix this, added the ? operator for a graceful fallback to false if undefined, so we can still view AKS Overview cards if plugin settings haven't been set yet.

How it looks:
image

To test- you can manually remove your plugin config with localStorage.removeItem('pluginConfigs') & then attempt to view an AKS project. You should see the AKS overview cards appear as intended.

Copilot AI review requested due to automatic review settings March 17, 2026 21:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an AKS Desktop rendering failure where AKS Project overview cards could disappear when the plugin config hasn’t been initialized (e.g., fresh install / localStorage.removeItem('pluginConfigs')), by preventing a runtime error while checking the GitHub Pipelines preview feature flag.

Changes:

  • Guard access to previewFeaturesStore.get() with optional chaining when deciding whether the Pipeline overview section is enabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@illume illume merged commit 6043a6b into Azure:main Mar 17, 2026
16 checks passed
@tejhan tejhan changed the title aksd: fix: AKS project overview cards dissapear when plugin config is not initialized. aksd: fix: AKS project overview cards disappear when plugin config is not initialized. Mar 17, 2026
gambtho pushed a commit to gambtho/aks-desktop that referenced this pull request Mar 17, 2026
aksd: fix: AKS project overview cards dissapear when plugin config is not initialized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants