Skip to content

introduce insights-plugin#481

Merged
gambtho merged 1 commit intomainfrom
flyth/insights-plugin/init
Mar 20, 2026
Merged

introduce insights-plugin#481
gambtho merged 1 commit intomainfrom
flyth/insights-plugin/init

Conversation

@flyth
Copy link
Copy Markdown
Member

@flyth flyth commented Mar 20, 2026

Description

The insights-plugin is built on Inspektor Gadget and IG Desktop and provides eBPF-based observability for AKS Deskop / Headlamp. The first version will add an "Insights" tab in the project view and allow deployment of Inspektor Gadget to the cluster.

See
https://github.com/inspektor-gadget/insights-plugin https://github.com/inspektor-gadget/inspektor-gadget https://github.com/inspektor-gadget/ig-desktop

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • CI/CD changes
  • Other: **___**

Copilot AI review requested due to automatic review settings March 20, 2026 11:47
Copilot AI reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces a new insights-plugin under plugins/ that integrates with the existing plugin build/CI pipeline by downloading pre-built release artifacts (Inspektor Gadget / IG Desktop-based) and validating them, and then ensuring the plugin is included in local bundling and CI matrices.

Changes:

  • Add plugins/insights-plugin with scripts to download and validate pre-built dist/ artifacts.
  • Register insights-plugin in the plugin build/bundling script (build/setup-plugins.ts).
  • Expand CI matrices to run build/test/lint/security jobs for insights-plugin.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
plugins/insights-plugin/scripts/validate-artifacts.sh Adds artifact validation checks for downloaded dist/ outputs.
plugins/insights-plugin/scripts/download-artifacts.sh Downloads a release tarball and extracts it into dist/.
plugins/insights-plugin/package.json Defines the plugin package and CI scripts (build downloads, test validates).
plugins/insights-plugin/.gitignore Ignores build outputs and downloaded archives for the new plugin.
build/setup-plugins.ts Adds insights-plugin to the list of plugins to build and copy into headlamp/.plugins.
.github/workflows/ci.yml Adds insights-plugin to the existing per-plugin CI job matrices.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 20, 2026 11:55
Copilot AI reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@flyth flyth force-pushed the flyth/insights-plugin/init branch from a4017f3 to b2435e3 Compare March 20, 2026 12:17
@flyth
Copy link
Copy Markdown
Member Author

flyth commented Mar 20, 2026

@copilot Addressed your concerns and pushed a new version. Please re-review.

Copilot AI mentioned this pull request Mar 20, 2026
Closed
Copy link
Copy Markdown

Copilot AI commented Mar 20, 2026

@flyth I've opened a new pull request, #482, to work on those changes. Once the pull request is ready, I'll request review from you.

@flyth
Copy link
Copy Markdown
Member Author

flyth commented Mar 20, 2026

@flyth I've opened a new pull request, #482, to work on those changes. Once the pull request is ready, I'll request review from you.

@copilot Let's stay in this PR, please.

Copy link
Copy Markdown

Copilot AI commented Mar 20, 2026

@flyth I've opened a new pull request, #483, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI mentioned this pull request Mar 20, 2026
Closed
@flyth flyth requested a review from Copilot March 20, 2026 12:27
Copilot AI reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@flyth flyth force-pushed the flyth/insights-plugin/init branch from b2435e3 to b203090 Compare March 20, 2026 12:47
@flyth flyth requested a review from Copilot March 20, 2026 12:48
Copilot AI reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@flyth flyth force-pushed the flyth/insights-plugin/init branch from b203090 to 239f3ca Compare March 20, 2026 13:09
Copilot AI review requested due to automatic review settings March 20, 2026 13:39
@flyth flyth force-pushed the flyth/insights-plugin/init branch from 239f3ca to 4d0034e Compare March 20, 2026 13:39
Copilot AI reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@flyth
introduce insights-plugin
bc8dffe 
The insights-plugin is built on Inspektor Gadget and IG Desktop and
provides eBPF-based observability for AKS Deskop / Headlamp. The first
version will add an "Insights" tab in the project view and allow deployment
of Inspektor Gadget to the cluster.

See
https://github.com/inspektor-gadget/insights-plugin
https://github.com/inspektor-gadget/inspektor-gadget
https://github.com/inspektor-gadget/ig-desktop

Signed-off-by: Michael Friese <mfriese@microsoft.com>
@flyth flyth force-pushed the flyth/insights-plugin/init branch from 4d0034e to bc8dffe Compare March 20, 2026 13:49
gambtho
gambtho approved these changes Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@gambtho gambtho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - tests without issue, disabled by default

@gambtho gambtho merged commit 21cd001 into main Mar 20, 2026
18 checks passed
@gambtho gambtho deleted the flyth/insights-plugin/init branch March 20, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@gambtho gambtho gambtho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@flyth @gambtho