Skip to content

Feat: add chart to deploy aks-mcp on kubernetes#207

Merged
feiskyer merged 4 commits intomainfrom
guwe/helm
Sep 18, 2025
Merged

Feat: add chart to deploy aks-mcp on kubernetes#207
feiskyer merged 4 commits intomainfrom
guwe/helm

Conversation

@gossion
Copy link
Member

@gossion gossion commented Sep 15, 2025

No description provided.

@gossion gossion marked this pull request as draft September 15, 2025 02:48
@gossion gossion marked this pull request as ready for review September 17, 2025 05:14
@gossion gossion requested a review from Copilot September 17, 2025 05:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a Helm chart to enable deployment of AKS-MCP on Kubernetes clusters. The chart provides a complete Kubernetes deployment configuration with support for both standard deployments and MCP Inspector integration for development/testing.

  • Complete Helm chart with configurable values, RBAC, services, and security contexts
  • Special MCP Inspector deployment configuration with OAuth support for development workflows
  • Deployment scripts and comprehensive documentation for different use cases

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
chart/Chart.yaml Helm chart metadata and version information
chart/values.yaml Main configuration file with app settings, Azure auth, OAuth, and Kubernetes resource definitions
chart/values-mcp-inspector.yaml Specialized values file optimized for MCP Inspector tool integration
chart/templates/_helpers.tpl Helm template helper functions for generating names, labels, and OAuth configurations
chart/templates/configmap.yaml ConfigMap template for application configuration
chart/templates/deployment.yaml Main deployment template with container configuration and environment variables
chart/templates/hpa.yaml Horizontal Pod Autoscaler template for scaling configuration
chart/templates/ingress.yaml Ingress template with multi-version API support
chart/templates/rbac.yaml RBAC ClusterRole and ClusterRoleBinding for Kubernetes permissions
chart/templates/secret.yaml Secret template for Azure credentials management
chart/templates/service.yaml Service template with NodePort and ClusterIP support
chart/templates/serviceaccount.yaml ServiceAccount template for pod identity
chart/scripts/deploy.sh Deployment script with environment validation and Helm operations
chart/MCP_INSPECTOR_DEPLOYMENT.md Comprehensive deployment guide for MCP Inspector integration
Comments suppressed due to low confidence (1)

chart/templates/deployment.yaml:1

  • Setting readOnlyRootFilesystem to false reduces security posture. Consider enabling this and using specific writable volume mounts for directories that need write access.
apiVersion: apps/v1

gossion and others added 3 commits September 17, 2025 22:07
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks addressing the comments, LGTM

@feiskyer feiskyer added this pull request to the merge queue Sep 18, 2025
Merged via the queue into main with commit 6cd6aa2 Sep 18, 2025
9 checks passed
@feiskyer feiskyer deleted the guwe/helm branch September 18, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants