Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Helm chart to enable deployment of AKS-MCP on Kubernetes clusters. The chart provides a complete Kubernetes deployment configuration with support for both standard deployments and MCP Inspector integration for development/testing.
- Complete Helm chart with configurable values, RBAC, services, and security contexts
- Special MCP Inspector deployment configuration with OAuth support for development workflows
- Deployment scripts and comprehensive documentation for different use cases
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| chart/Chart.yaml | Helm chart metadata and version information |
| chart/values.yaml | Main configuration file with app settings, Azure auth, OAuth, and Kubernetes resource definitions |
| chart/values-mcp-inspector.yaml | Specialized values file optimized for MCP Inspector tool integration |
| chart/templates/_helpers.tpl | Helm template helper functions for generating names, labels, and OAuth configurations |
| chart/templates/configmap.yaml | ConfigMap template for application configuration |
| chart/templates/deployment.yaml | Main deployment template with container configuration and environment variables |
| chart/templates/hpa.yaml | Horizontal Pod Autoscaler template for scaling configuration |
| chart/templates/ingress.yaml | Ingress template with multi-version API support |
| chart/templates/rbac.yaml | RBAC ClusterRole and ClusterRoleBinding for Kubernetes permissions |
| chart/templates/secret.yaml | Secret template for Azure credentials management |
| chart/templates/service.yaml | Service template with NodePort and ClusterIP support |
| chart/templates/serviceaccount.yaml | ServiceAccount template for pod identity |
| chart/scripts/deploy.sh | Deployment script with environment validation and Helm operations |
| chart/MCP_INSPECTOR_DEPLOYMENT.md | Comprehensive deployment guide for MCP Inspector integration |
Comments suppressed due to low confidence (1)
chart/templates/deployment.yaml:1
- Setting readOnlyRootFilesystem to false reduces security posture. Consider enabling this and using specific writable volume mounts for directories that need write access.
apiVersion: apps/v1
feiskyer
reviewed
Sep 17, 2025
feiskyer
reviewed
Sep 17, 2025
feiskyer
reviewed
Sep 17, 2025
feiskyer
reviewed
Sep 17, 2025
feiskyer
reviewed
Sep 17, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
feiskyer
approved these changes
Sep 18, 2025
Member
feiskyer
left a comment
There was a problem hiding this comment.
thanks addressing the comments, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.