Skip to content

build(node): limit node version to 18.13.0 #3097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2023
Merged

build(node): limit node version to 18.13.0 #3097

merged 1 commit into from
Feb 10, 2023
+7 −7

Conversation

@archerzz
Copy link
Member

@archerzz archerzz commented Feb 10, 2023

limit node version on our build agents to 18.13.0 to avoid mysterious mocha not found error

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@archerzz archerzz enabled auto-merge (squash) February 10, 2023 08:34
@archerzz archerzz merged commit 3dce34e into feature/v3 Feb 10, 2023
@archerzz archerzz deleted the build/limit-node-version branch February 10, 2023 09:32
mikeharder added a commit to mikeharder/autorest.csharp that referenced this pull request Feb 16, 2023
@mikeharder
Revert "build(node): limit node version to 18.13.0 (Azure#3097)"
489abaa 
This reverts commit 3dce34e.
@mikeharder mikeharder mentioned this pull request Feb 22, 2023
Closed
mikeharder added a commit to mikeharder/autorest.csharp that referenced this pull request Mar 17, 2023
@mikeharder
Revert "build(node): limit node version to 18.13.0 (Azure#3097)"
0a78226 
This reverts commit 3dce34e.
archerzz pushed a commit that referenced this pull request Mar 20, 2023
@mikeharder
Revert "build(node): limit node version to 18.13.0 (#3097)" (#3208)
869782d
ArcturusZhang pushed a commit to ArcturusZhang/autorest.csharp that referenced this pull request Mar 22, 2023
@mikeharder @ArcturusZhang
Revert "build(node): limit node version to 18.13.0 (Azure#3097)" (Azu…
e6d560b 
…re#3208)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunyu3 chunyu3 chunyu3 approved these changes

@AlexanderSher AlexanderSher Awaiting requested review from AlexanderSher

@lirenhe lirenhe Awaiting requested review from lirenhe

@m-nash m-nash Awaiting requested review from m-nash

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@archerzz @chunyu3