Skip to content

update the way we get singleton resource suffix #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 22, 2023
Merged

update the way we get singleton resource suffix #3119

merged 9 commits into from
Feb 22, 2023

Conversation

@ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Feb 15, 2023 •
edited
Loading

Fixes #2537
Original come from Azure/azure-sdk-for-net#31127
Regen: Azure/azure-sdk-for-net#34256

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang ArcturusZhang marked this pull request as ready for review February 15, 2023 09:26
Yao725
Yao725 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@Yao725 Yao725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArcturusZhang ArcturusZhang enabled auto-merge (squash) February 22, 2023 02:06
@ArcturusZhang ArcturusZhang merged commit 65c93d3 into Azure:feature/v3 Feb 22, 2023
@ArcturusZhang ArcturusZhang deleted the improve-singleton-resourceidentifier-builder branch February 22, 2023 04:55
ArcturusZhang added a commit to Azure/azure-sdk-for-net that referenced this pull request Feb 22, 2023
@ArcturusZhang
regen for Azure/autorest.csharp#3119 (#34256)
8b5fc14 
* regenerate

* regenerate after merge

* regenerate again after merge

* update version

* refresh api files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-nash m-nash m-nash approved these changes

@Yao725 Yao725 Yao725 approved these changes

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@AlexanderSher AlexanderSher Awaiting requested review from AlexanderSher

@lirenhe lirenhe Awaiting requested review from lirenhe

@chunyu3 chunyu3 Awaiting requested review from chunyu3

@jsquire jsquire Awaiting requested review from jsquire

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Introduce a Append method in ResourceIdentifier class and use it in singleton resource construction

3 participants

@ArcturusZhang @m-nash @Yao725