Skip to content

Support @projectedName #3147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 21, 2023
Merged

Support @projectedName #3147

merged 11 commits into from
Feb 21, 2023

Conversation

@ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Feb 17, 2023 •
edited
Loading

Fixes #3057
Regen: no changes in azure-sdk-for-net

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang ArcturusZhang marked this pull request as ready for review February 17, 2023 14:21
pshao25
pshao25 requested changes Feb 18, 2023
View reviewed changes
Copy link
Member

@pshao25 pshao25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests from cadl-ranch, not make it a made-up test.

pshao25
pshao25 reviewed Feb 20, 2023
View reviewed changes
pshao25
pshao25 reviewed Feb 20, 2023
View reviewed changes
ArcturusZhang
ArcturusZhang commented Feb 20, 2023
View reviewed changes
pshao25
pshao25 approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@pshao25 pshao25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ArcturusZhang ArcturusZhang merged commit aa049aa into Azure:feature/v3 Feb 21, 2023
@ArcturusZhang ArcturusZhang deleted the support-projectedName branch February 21, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lirenhe lirenhe lirenhe approved these changes

@pshao25 pshao25 pshao25 approved these changes

@m-nash m-nash Awaiting requested review from m-nash

@jsquire jsquire Awaiting requested review from jsquire

+1 more reviewer

@archerzz archerzz archerzz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support @projectedName for CADL+DPG

4 participants

@ArcturusZhang @archerzz @lirenhe @pshao25