Skip to content

Conversation

@chunyu3
Copy link
Member

@chunyu3 chunyu3 commented Feb 22, 2023

Description

Fix Azure/azure-sdk-for-net#34357

  • add dotnet build parameter to set cadl emitter options

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

Copy link
Member

@ArcturusZhang ArcturusZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very helpful, we no longer need to manually change the build script to add the extra flag

@chunyu3 chunyu3 requested review from ArcturusZhang and m-nash March 1, 2023 04:19
chunyu3 and others added 2 commits March 1, 2023 13:59
Co-authored-by: Dapeng Zhang <ufo54153@gmail.com>
@chunyu3 chunyu3 merged commit ade1cba into Azure:feature/v3 Mar 1, 2023
@chunyu3 chunyu3 deleted the setOption branch April 10, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] Improve the build script for typesepc/cadl projects

4 participants