Skip to content

Conversation

@chunyu3
Copy link
Member

@chunyu3 chunyu3 commented Mar 7, 2023

Description

Fix #3194

  • Only convert convenience type to object when the parameter is body parameter.

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@chunyu3 chunyu3 changed the title only convert to type object for body parameter Convert to type object for body parameter only Mar 7, 2023
@chunyu3
Copy link
Member Author

chunyu3 commented Mar 7, 2023

Regen azure-sdk-for-net, branch https://github.com/chunyu3/azure-sdk-for-net/tree/3194Fix, no change

@chunyu3 chunyu3 added the DPG label Mar 8, 2023
@chunyu3 chunyu3 merged commit 6699bcc into Azure:feature/v3 Mar 15, 2023
@chunyu3 chunyu3 deleted the 3194Fix branch July 12, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Defect] When parameter is array, the convenience method will generate as Object, and compile failed

3 participants