Skip to content

Conversation

@haiyuazhang
Copy link
Member

@haiyuazhang haiyuazhang commented May 9, 2025

Description

Add emitter option suppress-abstract-base-class to unblock servicefabricmanagedclusters TypeSpec conversion.

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@haiyuazhang haiyuazhang marked this pull request as draft May 9, 2025 06:50
@haiyuazhang haiyuazhang marked this pull request as ready for review May 14, 2025 06:49
@haiyuazhang haiyuazhang merged commit c224742 into Azure:main May 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants